New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix unnecessary ptr copy in HcalObjects #16388
Conversation
A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_8_1_X. It involves the following packages: CondFormats/HcalObjects @ghellwig, @cerminar, @cmsbuild, @franzoni, @ggovi, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
@cmsbuild please test |
The tests are being triggered in jenkins. |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison job queued. |
These changes look thread-safe. |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
@slava77 followup to #15959 (comment), this propagates the fix from df0c1b3 to all other affected classes in
CondFormats/HcalObjects
. CPU usage inHBHEIsolatedNoiseReflagger
is reduced dramatically (igprof output from step3 of WF 10024.0):attn: @igv4321