Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unnecessary ptr copy in HcalObjects #16388

Merged
merged 1 commit into from Nov 3, 2016

Conversation

kpedro88
Copy link
Contributor

@slava77 followup to #15959 (comment), this propagates the fix from df0c1b3 to all other affected classes in CondFormats/HcalObjects. CPU usage in HBHEIsolatedNoiseReflagger is reduced dramatically (igprof output from step3 of WF 10024.0):

CMSSW_8_1_X_2016-10-27-1100:             0.1  .........       0.13 / 0.13         HBHEIsolatedNoiseReflagger::produce(edm::Event&, edm::EventSetup const&) [2893]
                    PR15959:             0.1  .........       0.26 / 0.26         HBHEIsolatedNoiseReflagger::produce(edm::Event&, edm::EventSetup const&) [1932]
                     fixptr:             0.0  .........       0.02 / 0.02         HBHEIsolatedNoiseReflagger::produce(edm::Event&, edm::EventSetup const&) [6527]
             fixptr+PR15959:             0.0  .........       0.04 / 0.04         HBHEIsolatedNoiseReflagger::produce(edm::Event&, edm::EventSetup const&) [5496]

attn: @igv4321

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_8_1_X.

It involves the following packages:

CondFormats/HcalObjects

@ghellwig, @cerminar, @cmsbuild, @franzoni, @ggovi, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @apfeiffer1, @tocheng this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@kpedro88
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 29, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16059/console

@mmusich
Copy link
Contributor

mmusich commented Oct 29, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 29, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16060/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@Dr15Jones
Copy link
Contributor

These changes look thread-safe.

@mmusich
Copy link
Contributor

mmusich commented Nov 2, 2016

+1

@davidlange6 davidlange6 merged commit c288054 into cms-sw:CMSSW_8_1_X Nov 3, 2016
@ggovi
Copy link
Contributor

ggovi commented Nov 3, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants