updated Digitizer framework adding (a) option to allow independent El… #16389
Conversation
…ectronPerADC parameter for all four algorithms (b) threshold parameters changed Pixel:1000, PSP/PSS:63000 (0.4MIP) (c) overthreashold cut 1.4MIP for PSS and a large number (1.0E10) for all others (d) added occupancy plots in the validation suite [https://indico.cern.ch/event/536859/contributions/2354905/attachments/1362994/2063384/DigiStudy_Status_Oct28_2016.pdf]
|
A new Pull Request was created by @suchandradutta (Suchandra Dutta) for CMSSW_8_1_X. It involves the following packages: SimTracker/SiPhase2Digitizer @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
@suchandradutta , in SimTracker/SiPhase2Digitizer/test/DigiTest_cfg.py hardcoded file in /store/... is proposed instead of local file, which we are trying to avoid - this test soon will not work any more. Another minor comment: "Digitizer framework" in the title for me is ambiguous, because for CMS framework means something different. |
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-available
tests-approved
labels
|
Pull request #16389 was updated. @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please check and sign again. |
|
please test |
|
The tests are being triggered in jenkins. |
|
Pull request #16389 was updated. @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please check and sign again. |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
+1 |
cmsbuild
added
fully-signed
simulation-approved
and removed
pending-signatures
simulation-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
|
+1 |
The SiPhase2 Digitizer package has been updated. The details of the update can be found in following the presentation at the Tracker Phase2 Simulation Meeting
https://indico.cern.ch/event/536859/contributions/2354905/attachments/1362994/2063384/DigiStudy_Status_Oct28_2016.pdf
@delaere @boudoul @emiglior @atricomi