Fixing code of tau embedding (TauAnalysis/MCEmbeddingTools) for run2 needs part2

[swayand]

This PR contains only the cleanup of the old embedding code as it was requested in the original PR:

#16271

Two files need updates to keep it compile and compatible to initial PR. So please comment there.

[cmsbuild]

A new Pull Request was created by @swayand for CMSSW_8_1_X.

It involves the following packages:

TauAnalysis/MCEmbeddingTools

@cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[slava77]

On 11/1/16 4:48 PM, swayand wrote:

This PR contains only the cleanup of the old embedding code as it was
requested in the original PR:

#16271 #16271

Two files need updates to keep it compile and compatible to initial PR.
So please comment there.

Do you mean that this PR would not compile as is?
If so, it will stay on hold until 16271 is ready and merged.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#16418, or mute the thread
https://github.com/notifications/unsubscribe-auth/AEdcbp5fxsd74VPsUqFXyh3BfwgGCruQks5q58_AgaJpZM4Kmtsw.

[swayand]

Sorry it means with the few files which are edited (with the same changes as in the #16271 ) it compiles.

[civanch]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16137/console

[cmsbuild]

+1
Tested at: 71f284c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16418/16137/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16418/16137/summary.html

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

[davidlange6]

+1