Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for pPb relvals (81X) #16442

Merged
merged 4 commits into from Nov 3, 2016

Conversation

fabozzi
Copy link
Contributor

@fabozzi fabozzi commented Nov 3, 2016

New pPb data relval
Updated pPb MC relval to use HLT:PIon

Supercedes PR #16424

@mandrenguyen
This is for 81X. When #16394 (for run1_pA era) will be merged, we can make backport to 80X.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2016

A new Pull Request was created by @fabozzi for CMSSW_8_1_X.

It involves the following packages:

Configuration/PyReleaseValidation

@cmsbuild, @srimanob, @davidlange6, @hengne, @fabozzi can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @ghellwig this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@fabozzi
Copy link
Contributor Author

fabozzi commented Nov 3, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16167/console

@@ -1210,7 +1210,10 @@ def lhegensim(fragment,howMuch):
steps['RECOUP15_trackingOnlyLowPU']=merge([step3_trackingLowPU, step3Up2015Defaults_trackingOnly]) # todo: remove UP from label
steps['RECOUP15_HIPM']=merge([step3_HIPM,step3Up2015Defaults]) # todo: remove UP from label

# for Run2 PPb workflows
# for Run1 PPb data workflow
steps['RECO_PPbData']=merge([{'-s':'RAW2DIGI,L1Reco,RECO,ALCA:TkAlMinBias+TkAlMuonIsolatedPA+TkAlUpsilonMuMuPA+TkAlZMuMuPA,SKIM:ZMM+ZEE+MinBias,EI,DQM','--scenario':'pp','--conditions':'auto:run2_data','--era':'Run1_pA','--datatier':'AOD,DQMIO','--eventcontent':'AOD,DQM'}, dataReco])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

auto:run2_data better be auto:run1_data at least for semantic purpose (the two are identical since a while)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, changing

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2016

Pull request #16442 was updated. @cmsbuild, @srimanob, @davidlange6, @hengne, @fabozzi can you please check and sign again.

@fabozzi
Copy link
Contributor Author

fabozzi commented Nov 3, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2016

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2016

Pull request #16442 was updated. @cmsbuild, @srimanob, @davidlange6, @hengne, @fabozzi can you please check and sign again.

@fabozzi
Copy link
Contributor Author

fabozzi commented Nov 3, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16168/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2016

-1

Tested at: 2116766

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16442/16167/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2016

Pull request #16442 was updated. @cmsbuild, @srimanob, @davidlange6, @hengne, @fabozzi can you please check and sign again.

@fabozzi
Copy link
Contributor Author

fabozzi commented Nov 3, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16171/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2016

Comparison job queued.

@fabozzi
Copy link
Contributor Author

fabozzi commented Nov 3, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2016

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16442/16171/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • 23224.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2023D5_GenSimHLBeamSpotFull+DigiFull_2023D5+RecoFullGlobal_2023D5+HARVESTFullGlobal_2023D5

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a58f7e2 into cms-sw:CMSSW_8_1_X Nov 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants