New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for pPb relvals (81X) #16442
Updates for pPb relvals (81X) #16442
Conversation
A new Pull Request was created by @fabozzi for CMSSW_8_1_X. It involves the following packages: Configuration/PyReleaseValidation @cmsbuild, @srimanob, @davidlange6, @hengne, @fabozzi can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
please test |
The tests are being triggered in jenkins. |
@@ -1210,7 +1210,10 @@ def lhegensim(fragment,howMuch): | |||
steps['RECOUP15_trackingOnlyLowPU']=merge([step3_trackingLowPU, step3Up2015Defaults_trackingOnly]) # todo: remove UP from label | |||
steps['RECOUP15_HIPM']=merge([step3_HIPM,step3Up2015Defaults]) # todo: remove UP from label | |||
|
|||
# for Run2 PPb workflows | |||
# for Run1 PPb data workflow | |||
steps['RECO_PPbData']=merge([{'-s':'RAW2DIGI,L1Reco,RECO,ALCA:TkAlMinBias+TkAlMuonIsolatedPA+TkAlUpsilonMuMuPA+TkAlZMuMuPA,SKIM:ZMM+ZEE+MinBias,EI,DQM','--scenario':'pp','--conditions':'auto:run2_data','--era':'Run1_pA','--datatier':'AOD,DQMIO','--eventcontent':'AOD,DQM'}, dataReco]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
auto:run2_data better be auto:run1_data at least for semantic purpose (the two are identical since a while)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, changing
please test |
The tests are being triggered in jenkins. |
please test |
The tests are being triggered in jenkins. |
-1 Tested at: 2116766 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
|
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
|
+1 |
New pPb data relval
Updated pPb MC relval to use HLT:PIon
Supercedes PR #16424
@mandrenguyen
This is for 81X. When #16394 (for run1_pA era) will be merged, we can make backport to 80X.