Fix to pA skim names #16478
Fix to pA skim names #16478
Conversation
|
A new Pull Request was created by @mandrenguyen for CMSSW_8_0_X. It involves the following packages: Configuration/Skimming @cmsbuild, @srimanob, @davidlange6, @hengne, @fabozzi can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
@cmsbuild please test |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
cmsbuild
added
fully-signed
pdmv-approved
and removed
pdmv-pending
pending-signatures
labels
|
+1 |
| @@ -12,7 +12,7 @@ | |||
|
|
|||
There was a problem hiding this comment.
It looks like the import of EventContentHeavyIons_cff is breaking the replay with 8_0_23.
Load of this files leads to override of all the standard EventContent (AOD, RAW, Reco, ) with their HI extensions.
Specifically, one of the overrides comes from RecoHiEgamma_EventContent_cff from RecoHiEgammaAOD, which has some ill-formed keep floatedmValueMap_*_*_*.
I would be still OK, if we were not running miniAOD: regular reco config setup purges the unnecessary ak8PFJetsCHSFilteredMass and its upstream ak8PFJetsCHSFiltered from the configuration when creating unscheduled configuration; but then miniAOD loads it back again in PhysicsTools/PatAlgos/python/slimming/applySubstructure_cff.py as process.load("RecoJets.JetProducers.ak8PFJetsCHS_groomingValueMaps_cfi") and there it loads only ak8PFJetsCHSFilteredMass and there is no downstream consumers of it in miniAOD and in this case this module should not run ... except that you have now inadvertently added keep floatedmValueMap_*_*_* which makes ak8PFJetsCHSFilteredMass runnable.
We didn't hit any of these fun parts with keep * in 2015 PbPb run because we did not run miniAOD.
If we are running the standard pp sequence with some small additions and edits of modules for pA needs, the FEVT event content has to be also the standard EventContent_cff.
So, please change the above
from Configuration.EventContent.EventContentHeavyIons_cff import FEVTEventContent
to
from Configuration.EventContent.EventContent_cff import FEVTEventContent
There was a problem hiding this comment.
Submitting a PR now with the change to pp event content. Btw, we shouldn't be producing mini-AOD, as far as I understood.
The stream names also needed to be updated for these skims to run.