Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pixel Geometry Fixes #16519

Merged
merged 2 commits into from Nov 11, 2016
Merged

Conversation

schneiml
Copy link
Contributor

@schneiml schneiml commented Nov 8, 2016

These two commits should fix the Phase1 Pixel geometry issues reported in the Offline week diskussion.

The pixbar volumes touched here were not modified for a long time, and it is not clear why the subtraction was used there in the first place. It seems safe to remove it, but this should be checked again.

We attempted to compensate the material budget changes by adjusting the material densities accordingly, even though the change is probably within the tolerance of these numbers.

Subtraction is not needed, width reduced to not conflct with tube
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2016

A new Pull Request was created by @schneiml (Marcel Schneider) for CMSSW_8_1_X.

It involves the following packages:

Geometry/TrackerCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @ghellwig, @venturia, @VinInn, @ghugo83 this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@ianna
Copy link
Contributor

ianna commented Nov 8, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16260/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2016

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2016

@ianna
Copy link
Contributor

ianna commented Nov 9, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@ianna
Copy link
Contributor

ianna commented Nov 9, 2016

@civanch and @davidlange6 - comparing with previous display the overlaps in Pixel are fixed.
with this PR:
screen shot 2016-11-09 at 16 45 02
screen shot 2016-11-09 at 16 40 59
before:
screenshot 2016-11-07 12 02 14
screenshot 2016-11-07 12 21 30

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 333f839 into cms-sw:CMSSW_8_1_X Nov 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants