bsunanda:Phase2-ft09 Add Reco geometry for Fast Timing #16562
Conversation
|
@cmsbuild Please test |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @bsunanda for CMSSW_8_1_X. It involves the following packages: Geometry/CaloEventSetup @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
@ianna It will be nice if this could be a part of 8_1_0 |
|
Comparison job queued. |
|
@ianna could you approve this so that it can be a part of 8_1_0? |
|
@lgray This is the very first attempt - I have not yet tested it. The test function is to be written for this and then I update the scenario |
|
@bsunanda Thanks, I'll take a look ASAP. |
|
@ianna Please approve this |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
| DetId nextId= goNorth(id); | ||
| std::vector<DetId> vNeighborsDetId; | ||
| if (! (nextId==DetId(0))) | ||
| vNeighborsDetId.push_back(DetId(nextId.rawId())); |
There was a problem hiding this comment.
@bsunanda - why the conversion from DetId to uint back to DetId?
There was a problem hiding this comment.
I shall correct this later on. But most likely we would not use the neighbor code immediately. Please include this in 8_1_0 and the improved code will be put for 9_0_X. I spotted similar problem in HGCalTopology class as well
There was a problem hiding this comment.
so how do you propose to keep track of the issue (seems more work to remember than to fix..)
|
@davidlange6 If you integrate this now I shall put up the next PR once I have the new IB. It will repair not only this Topology class and all the others in this package |
|
+1 |
This is the first attempt to provide reconstruction geometry for fast timing layers