Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add customization function to switch the pixelTracks for the iterativ… #16563

Merged
merged 9 commits into from Dec 1, 2016
Merged

add customization function to switch the pixelTracks for the iterativ… #16563

merged 9 commits into from Dec 1, 2016

Conversation

JanFSchulte
Copy link
Contributor

…e tracking for PF at HLT to use quadruplets created by the Cellular Automaton and adapts the iterative tracking accordingly. Does not switch any other pixelTrackProducers that are in the menu.

…e tracking for PF at HLT to use quadruplets created by the Cellular Automaton
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @JanFSchulte (Jan-Frederik Schulte) for CMSSW_8_1_X.

It involves the following packages:

HLTrigger/Configuration

@perrotta, @cmsbuild, @silviodonato, @Martin-Grunewald, @fwyzard, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @geoff-smith, @jalimena this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@silviodonato
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 11, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16320/console

@Martin-Grunewald
Copy link
Contributor

This will never work in a robust way!
I see hardwired module labels, and we know we change labels sometimes.
Even worse, I see hardwired HLT path names with version numbers, and those are also changed.
This code requires an enormous maintenance effort for an evolving menu.
We should restrict it to a single menu or make the code better in dealing with developments of the menu itself.

@JanFSchulte
Copy link
Contributor Author

Well, most of it changes the irerative tracking, which will not be changed without me knowing it, so this is no problem. I agree that the changes to hardcoded sequences is very ugly. If you have a suggestion how to dynamically replace process.hltPixelLayerTriplets with process.hltPixelLayerQuadruplets in sequences, I am happy to make this less dependent on the specific menu.

@fwyzard
Copy link
Contributor

fwyzard commented Nov 11, 2016 via email

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #16563 was updated. @perrotta, @cmsbuild, @silviodonato, @Martin-Grunewald, @fwyzard, @davidlange6 can you please check and sign again.

@cmsbuild
Copy link
Contributor

Pull request #16563 was updated. @perrotta, @cmsbuild, @silviodonato, @Martin-Grunewald, @fwyzard, @davidlange6 can you please check and sign again.

@Martin-Grunewald
Copy link
Contributor

-1
No proliferation of small files. Collect all customisations in a single py file as separate python routines
(to be stichted together on the cmsDriver cmdline).

@cmsbuild
Copy link
Contributor

… dynamic and move everythin into a single file
@cmsbuild
Copy link
Contributor

Pull request #16563 was updated. @perrotta, @cmsbuild, @silviodonato, @Martin-Grunewald, @fwyzard, @davidlange6 can you please check and sign again.

@JanFSchulte
Copy link
Contributor Author

@Martin-Grunewald @makortel This should adress both of your commets.

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 29, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16643/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit faadba4 into cms-sw:CMSSW_8_1_X Dec 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet