remove a bunch of unneeded Pythia6 configs #16578

kpedro88 · 2016-11-14T20:18:27Z

@davidlange6 @hengne requested followup to #16535. I went through and found all the Pythia6 configs in Configuration/Generator that had obvious Pythia8 counterparts (identical filenames except with either "TuneCUETP8M1" or "pythia8" in the newer version). I also checked that none of the removed files are used anywhere in Configuration/PyReleaseValidation.

There are still a number of configs that don't have any Pythia8 counterpart. If PDMV wants to move all of those to Pythia8 as well, probably better to appoint someone to do it...

cmsbuild · 2016-11-14T20:18:47Z

A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_8_1_X.

It involves the following packages:

Configuration/Generator

@cmsbuild, @govoni, @perrozzi, @thuer, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

kpedro88 · 2016-11-14T20:20:48Z

@cmsbuild please test

cmsbuild · 2016-11-14T20:21:05Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16341/console

cmsbuild · 2016-11-14T21:35:31Z

-1

Tested at: 3ae5369

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16578/16341/summary.html

I found follow errors while testing this PR

Failed tests: AddOn

AddOn:

I found errors in the following addon tests:

cmsDriver.py TTbar_Tauola_13TeV_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --magField 38T_PostLS1 --fileout file:RelVal_Raw_GRun_MC.root : FAILED - time: date Mon Nov 14 22:08:54 2016-date Mon Nov 14 22:08:00 2016 s - exit: 256
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_1_X_2016-11-14-1100/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Mon Nov 14 22:08:54 2016-date Mon Nov 14 22:08:00 2016 s - exit: 21504
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_GRun_MC.root --fileout file:RelVal_Raw_GRun_MC_HLT_RECO.root : FAILED - time: date Mon Nov 14 22:08:54 2016-date Mon Nov 14 22:08:00 2016 s - exit: 21504
cmsDriver.py TTbar_Tauola_13TeV_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_PRef --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --magField 38T_PostLS1 --fileout file:RelVal_Raw_PRef_MC.root : FAILED - time: date Mon Nov 14 22:08:43 2016-date Mon Nov 14 22:08:04 2016 s - exit: 256
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_1_X_2016-11-14-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Mon Nov 14 22:08:43 2016-date Mon Nov 14 22:08:04 2016 s - exit: 21504
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PRef_MC.root --fileout file:RelVal_Raw_PRef_MC_HLT_RECO.root : FAILED - time: date Mon Nov 14 22:08:43 2016-date Mon Nov 14 22:08:04 2016 s - exit: 21504
cmsDriver.py TTbar_Tauola_8TeV_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run1_mc_Fake --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --fileout file:RelVal_Raw_Fake_MC.root : FAILED - time: date Mon Nov 14 22:08:43 2016-date Mon Nov 14 22:08:09 2016 s - exit: 256
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_1_X_2016-11-14-1100/src/HLTrigger/Configuration/test/OnLine_HLT_Fake.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Mon Nov 14 22:08:43 2016-date Mon Nov 14 22:08:09 2016 s - exit: 21504
cmsDriver.py RelVal -s HLT:Fake,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run1_mc_Fake --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --processName=HLTRECO --filein file:RelVal_Raw_Fake_MC.root --fileout file:RelVal_Raw_Fake_MC_HLT_RECO.root : FAILED - time: date Mon Nov 14 22:08:43 2016-date Mon Nov 14 22:08:09 2016 s - exit: 21504
cmsDriver.py TTbar_Tauola_13TeV_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=HeavyIons -n 10 --conditions auto:run2_mc_HIon --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016,Run2_HI --magField 38T_PostLS1 --fileout file:RelVal_Raw_HIon_MC.root : FAILED - time: date Mon Nov 14 22:08:50 2016-date Mon Nov 14 22:08:14 2016 s - exit: 256
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_1_X_2016-11-14-1100/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Mon Nov 14 22:08:50 2016-date Mon Nov 14 22:08:14 2016 s - exit: 21504
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --mc --scenario=HeavyIons -n 10 --conditions auto:run2_mc_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016,Run2_HI --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_HIon_MC.root --fileout file:RelVal_Raw_HIon_MC_HLT_RECO.root : FAILED - time: date Mon Nov 14 22:08:50 2016-date Mon Nov 14 22:08:14 2016 s - exit: 21504
cmsDriver.py TTbar_Tauola_13TeV_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake1 --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_25ns --fileout file:RelVal_Raw_Fake1_MC.root : FAILED - time: date Mon Nov 14 22:08:54 2016-date Mon Nov 14 22:08:18 2016 s - exit: 256
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_1_X_2016-11-14-1100/src/HLTrigger/Configuration/test/OnLine_HLT_Fake1.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Mon Nov 14 22:08:54 2016-date Mon Nov 14 22:08:18 2016 s - exit: 21504
cmsDriver.py RelVal -s HLT:Fake1,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake1 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_25ns --processName=HLTRECO --filein file:RelVal_Raw_Fake1_MC.root --fileout file:RelVal_Raw_Fake1_MC_HLT_RECO.root : FAILED - time: date Mon Nov 14 22:08:54 2016-date Mon Nov 14 22:08:18 2016 s - exit: 21504
cmsDriver.py TTbar_Tauola_13TeV_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_PIon --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --magField 38T_PostLS1 --fileout file:RelVal_Raw_PIon_MC.root : FAILED - time: date Mon Nov 14 22:09:16 2016-date Mon Nov 14 22:08:36 2016 s - exit: 256
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_1_X_2016-11-14-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Mon Nov 14 22:09:16 2016-date Mon Nov 14 22:08:36 2016 s - exit: 21504
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PIon_MC.root --fileout file:RelVal_Raw_PIon_MC_HLT_RECO.root : FAILED - time: date Mon Nov 14 22:09:16 2016-date Mon Nov 14 22:08:36 2016 s - exit: 21504

cmsbuild · 2016-11-14T21:35:34Z

Comparison job queued.

cmsbuild · 2016-11-14T21:58:08Z

Pull request #16578 was updated. @perrotta, @smuzaffar, @Dr15Jones, @silviodonato, @perrozzi, @thuer, @dmitrijus, @Martin-Grunewald, @cmsbuild, @fwyzard, @vanbesien, @govoni, @davidlange6 can you please check and sign again.

kpedro88 · 2016-11-14T21:58:55Z

The AddOn test failure demonstrates that some of these configs might be used outside of relvals, so I checked for any usage of each file and updated that usage to the pythia8 version.

kpedro88 · 2016-11-14T22:14:03Z

@cmsbuild please test

cmsbuild · 2016-11-14T22:14:17Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16344/console

cmsbuild · 2016-11-14T23:01:23Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16578/16341/summary.html

Alternative comparison was/were failed for workflow(s):
23224.0

cmsbuild · 2016-11-15T00:16:25Z

+1
Tested at: 43861ff
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16578/16344/summary.html

cmsbuild · 2016-11-15T00:16:28Z

Comparison job queued.

cmsbuild · 2016-11-15T02:11:52Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16578/16344/summary.html

dmitrijus · 2016-11-15T12:51:11Z

+1

perrozzi · 2016-11-15T13:15:44Z

+1

Martin-Grunewald · 2016-11-15T15:09:23Z

+1

kpedro88 added 2 commits November 14, 2016 14:04

remove a bunch of unneeded Pythia6 configs

1808fb2

remove unneeded pythia6 particle gun configs

3ae5369

cmsbuild added this to the Next CMSSW_8_1_X milestone Nov 14, 2016

cmsbuild added comparison-pending generators-pending orp-pending pending-signatures tests-pending labels Nov 14, 2016

cmsbuild added tests-started and removed tests-pending labels Nov 14, 2016

cmsbuild added tests-rejected and removed tests-started labels Nov 14, 2016

fix all usage of removed configs

43861ff

cmsbuild added core-pending dqm-pending hlt-pending tests-pending and removed tests-rejected labels Nov 14, 2016

cmsbuild added tests-started and removed tests-pending labels Nov 14, 2016

cmsbuild added comparison-available and removed comparison-pending labels Nov 14, 2016

cmsbuild added comparison-pending tests-approved and removed comparison-available tests-started labels Nov 15, 2016

cmsbuild added comparison-available and removed comparison-pending labels Nov 15, 2016

cmsbuild added dqm-approved and removed dqm-pending labels Nov 15, 2016

cmsbuild added generators-approved and removed generators-pending labels Nov 15, 2016

cmsbuild added hlt-approved and removed hlt-pending labels Nov 15, 2016

davidlange6 merged commit f81ff5d into cms-sw:CMSSW_8_1_X Nov 15, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

remove a bunch of unneeded Pythia6 configs #16578

remove a bunch of unneeded Pythia6 configs #16578

kpedro88 commented Nov 14, 2016

cmsbuild commented Nov 14, 2016

kpedro88 commented Nov 14, 2016

cmsbuild commented Nov 14, 2016 •

edited

cmsbuild commented Nov 14, 2016

cmsbuild commented Nov 14, 2016

cmsbuild commented Nov 14, 2016

kpedro88 commented Nov 14, 2016

kpedro88 commented Nov 14, 2016

cmsbuild commented Nov 14, 2016 •

edited

cmsbuild commented Nov 14, 2016

cmsbuild commented Nov 15, 2016

cmsbuild commented Nov 15, 2016

cmsbuild commented Nov 15, 2016

dmitrijus commented Nov 15, 2016

perrozzi commented Nov 15, 2016

Martin-Grunewald commented Nov 15, 2016

remove a bunch of unneeded Pythia6 configs #16578

remove a bunch of unneeded Pythia6 configs #16578

Conversation

kpedro88 commented Nov 14, 2016

cmsbuild commented Nov 14, 2016

kpedro88 commented Nov 14, 2016

cmsbuild commented Nov 14, 2016 • edited

cmsbuild commented Nov 14, 2016

cmsbuild commented Nov 14, 2016

cmsbuild commented Nov 14, 2016

kpedro88 commented Nov 14, 2016

kpedro88 commented Nov 14, 2016

cmsbuild commented Nov 14, 2016 • edited

cmsbuild commented Nov 14, 2016

cmsbuild commented Nov 15, 2016

cmsbuild commented Nov 15, 2016

cmsbuild commented Nov 15, 2016

dmitrijus commented Nov 15, 2016

perrozzi commented Nov 15, 2016

Martin-Grunewald commented Nov 15, 2016

cmsbuild commented Nov 14, 2016 •

edited

cmsbuild commented Nov 14, 2016 •

edited