Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sin cos #1658

Merged
merged 2 commits into from Dec 4, 2013
Merged

Sin cos #1658

merged 2 commits into from Dec 4, 2013

Conversation

VinInn
Copy link
Contributor

@VinInn VinInn commented Dec 3, 2013

use vdt instead of x87 sincos

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2013

A new Pull Request was created by @VinInn for CMSSW_7_0_X.

Sin cos

It involves the following packages:

TrackingTools/AnalyticalJacobians
TrackingTools/GeomPropagators

@nclopezo, @cmsbuild, @thspeer, @slava77 can you please review it and eventually sign? Thanks.
@gpetruc, @cerati, @GiacomoSguazzoni, @rovere this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2013

@thspeer
Copy link
Contributor

thspeer commented Dec 4, 2013

+1
tested 0440f7f in CMSSW_7_0_X_2013-12-03-0200-1658
No difference in reco, based on RelMon and reco script

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2013

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

nclopezo added a commit that referenced this pull request Dec 4, 2013
@nclopezo nclopezo merged commit 0a0e1e7 into cms-sw:CMSSW_7_0_X Dec 4, 2013
@VinInn VinInn deleted the SinCos branch July 13, 2016 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants