Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some DQM sequences for phase1 scenario #16589

Merged
merged 4 commits into from Nov 27, 2016

Conversation

mtosi
Copy link
Contributor

@mtosi mtosi commented Nov 15, 2016

thanks to @makortel
I went through the list of python config files which still handle the phase1
by dropping some DQM/Validation modules

I did not update the following ones, though

  • DQMOffline/Configuration/python/DQMOffline_CRT_cff.py:phase1Pixel.toReplaceWith(crt_dqmoffline, crt_dqmoffline.copyAndExclude([ # FIXME
  • Validation/RecoTrack/python/SiTrackingRecHitsValid_cff.py:phase1Pixel.toReplaceWith(trackingRecHitsValid, trackingRecHitsValid.copyAndExclude([ # FIXME

because the comment suggests that need some work on the DQM side

in addition, I was not able to merge my original updates
because of conflict w/

  • DQM/Physics/python/DQMPhysics_cff.py:phase1Pixel.toReplaceWith(dqmPhysics, dqmPhysics.copyAndExclude([ # FIXME
    so, it still needs to be updated

I do not think they are super urgent, but I would suggest to integrate this PR as soon as possible ...

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mtosi (mia tosi) for CMSSW_8_1_X.

It involves the following packages:

DQM/SiStripMonitorClient
DQMOffline/JetMET
DQMOffline/Muon
Validation/Configuration
Validation/RecoTau

@civanch, @cvuosalo, @mdhildreth, @dmitrijus, @cmsbuild, @slava77, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@rappoccio, @abbiendi, @TaiSakuma, @fioriNTU, @threus, @venturia, @mmarionncern, @hdelanno, @battibass, @ahinzmann, @jhgoh, @jdolen, @HuguesBrun, @ptcox, @trocino, @rociovilar, @barvic, @bellan, @nhanvtran, @gkasieczka, @schoef, @idebruyn, @calderona, @mariadalfonso this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@slava77
Copy link
Contributor

slava77 commented Nov 15, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 15, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16359/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@makortel
Copy link
Contributor

Thanks Mia! I hope the DQM team could follow up the remaining issues.

@slava77
Copy link
Contributor

slava77 commented Nov 21, 2016

+1

for #16589 1258b10

  • reco is not affected. Updates are made in dqm/validation configs for phase-1.
  • jenkins tests pass and comparisons with baseline show differences only in DQM plots in 2017 workflows. Most visible changes are in the tau plots which appear to be normalized now in a way similar to the 2016 workflows.

@civanch
Copy link
Contributor

civanch commented Nov 22, 2016

+1

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6 davidlange6 merged commit 482fa5a into cms-sw:CMSSW_8_1_X Nov 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants