New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FastSimulation Threaded Random Numbers #1661
FastSimulation Threaded Random Numbers #1661
Conversation
Changes in FastSimulation code to migrate it to the new threaded interface of the random number service. In the new interface the service must be passed the StreamID in the event or the LuminosityBlockIndex in the beginLuminosityBlock method. Note a few areas had problems which are not resolved yet and are marked with the comment RANDOM_NUMBER_ERROR. These were problems in the prior version also.
This is the same as pull request 1524 except I rebased it and resolved the conflicts between it and other changes that were integrated into 7_0_X while this set of changes was waiting for approval. I ran checkdeps -a and the limited runTheMatrix tests again on this new pull request. |
A new Pull Request was created by @wddgit (W. David Dagenhart) for CMSSW_7_0_X. FastSimulation Threaded Random Numbers It involves the following packages: FastSimulation/ParticlePropagator @cmsbuild, @nclopezo, @giamman, @lveldere can you please review it and eventually sign? Thanks. |
+1 |
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it? |
-1 runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/step2_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM.log you can see the results of the tests here: |
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it? |
The error seems to be unrelated. |
FastSimulation Threaded Random Numbers
Advance data-RecoEgamma ElectronIdentification and PhotonIdentification.
Changes in FastSimulation code to migrate it to
the new threaded interface of the random number
service. In the new interface the service must
be passed the StreamID in the event or the
LuminosityBlockIndex in the beginLuminosityBlock
method. Note a few areas had problems which are
not resolved yet and are marked with the comment
RANDOM_NUMBER_ERROR. These were problems in the
prior version also.