Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FastSimulation Threaded Random Numbers #1661

Merged
merged 1 commit into from Dec 4, 2013

Conversation

wddgit
Copy link
Contributor

@wddgit wddgit commented Dec 3, 2013

Changes in FastSimulation code to migrate it to
the new threaded interface of the random number
service. In the new interface the service must
be passed the StreamID in the event or the
LuminosityBlockIndex in the beginLuminosityBlock
method. Note a few areas had problems which are
not resolved yet and are marked with the comment
RANDOM_NUMBER_ERROR. These were problems in the
prior version also.

Changes in FastSimulation code to migrate it to
the new threaded interface of the random number
service. In the new interface the service must
be passed the StreamID in the event or the
LuminosityBlockIndex in the beginLuminosityBlock
method. Note a few areas had problems which are
not resolved yet and are marked with the comment
RANDOM_NUMBER_ERROR. These were problems in the
prior version also.
@wddgit
Copy link
Contributor Author

wddgit commented Dec 3, 2013

This is the same as pull request 1524 except I rebased it and resolved the conflicts between it and other changes that were integrated into 7_0_X while this set of changes was waiting for approval. I ran checkdeps -a and the limited runTheMatrix tests again on this new pull request.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2013

A new Pull Request was created by @wddgit (W. David Dagenhart) for CMSSW_7_0_X.

FastSimulation Threaded Random Numbers

It involves the following packages:

FastSimulation/ParticlePropagator
FastSimulation/CaloHitMakers
FastSimulation/PileUpProducer
FastSimulation/Event
FastSimulation/Utilities
FastSimulation/MaterialEffects
FastSimulation/Calorimetry
FastSimulation/TrackingRecHitProducer
FastSimulation/EventProducer
FastSimulation/CaloRecHitsProducer
FastSimulation/MuonSimHitProducer
FastSimulation/TrajectoryManager
FastSimulation/CaloGeometryTools
FastSimulation/ShowerDevelopment

@cmsbuild, @nclopezo, @giamman, @lveldere can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@lveldere
Copy link
Contributor

lveldere commented Dec 4, 2013

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2013

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2013

-1
When I ran the RelVals I found an error in the following worklfows:
1003.0 step2

runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/step2_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1661/1577/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2013

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

@nclopezo
Copy link
Contributor

nclopezo commented Dec 4, 2013

The error seems to be unrelated.

@nclopezo
Copy link
Contributor

nclopezo commented Dec 4, 2013

nclopezo added a commit that referenced this pull request Dec 4, 2013
@nclopezo nclopezo merged commit 62b0f1e into cms-sw:CMSSW_7_0_X Dec 4, 2013
@wddgit wddgit deleted the fastSimThreadedRandomNumbers branch December 12, 2013 19:31
ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
Advance data-RecoEgamma ElectronIdentification and PhotonIdentification.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants