Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HCAL 2017 HF TP dual-anode readout fixes. #16618

Merged
merged 2 commits into from Nov 16, 2016

Conversation

cmsbuild
Copy link
Contributor

Fix the energy calculation to match firmware. Duplicate valid energies when one part of the readout fails, and shift over the lower energy bits properly.
Automatically ported from CMSSW_8_1_X #16464 (original by @matz-e).

The previous iteration used slides as a base for the code, using
divisions for adjusting for the dual-anode read-out.  Use
multiplications instead, as in the uHTR spec and add an omitted shift
for the right LSB.
@cmsbuild
Copy link
Contributor Author

A new Pull Request was created by @cmsbuild for CMSSW_9_0_X.

It involves the following packages:

SimCalorimetry/HcalTrigPrimAlgos

@cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@davidlange6 davidlange6 merged commit 5b6c9eb into cms-sw:CMSSW_9_0_X Nov 16, 2016
@matz-e matz-e deleted the hcal-tp-2017-divisions branch September 15, 2017 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants