Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ME0 pseudo digitizer: Fix the BX mixing window + enable bkg scaling with lumi #16632

Merged
merged 4 commits into from Nov 24, 2016
Merged

ME0 pseudo digitizer: Fix the BX mixing window + enable bkg scaling with lumi #16632

merged 4 commits into from Nov 24, 2016

Conversation

cmsbuild
Copy link
Contributor

It appears that in the ME0 pseudo digitizer module the TOF distribution corresponding to BX=0 in the BX window [-5,3] is centered at -7.5 ns. It should be at 18.5 ns (distance from ME0 to beam-spot). This pull request fixes that. The effect is visible when comparing the TOF from hits at PU200. See plots below.

screen shot 2016-10-19 at 16 29 58

screen shot 2016-10-19 at 16 30 08

The second part of this pull request enables to scale up/down the electron/neutron background for desired instantaneous lumi (reference is 5E34, double from config is in units of 1E34).

@nickmccoll @pietverwilligen

Automatically ported from CMSSW_8_1_X #16273 (original by @dildick).

@cmsbuild
Copy link
Contributor Author

A new Pull Request was created by @cmsbuild for CMSSW_9_0_X.

It involves the following packages:

SimMuon/GEMDigitizer

@cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks.
@jhgoh this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@mdhildreth
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Nov 22, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16551/console

@cmsbuild
Copy link
Contributor Author

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor Author

@cmsbuild
Copy link
Contributor Author

Comparison job queued.

@cmsbuild
Copy link
Contributor Author

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 1e597a6 into cms-sw:CMSSW_9_0_X Nov 24, 2016
@dildick dildick deleted the fix-ME0-pseudo-digi-bx-mixing-window branch July 21, 2017 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants