Fix MultiTrackValidator MVA monitoring (81X)

[makortel]

Backport of #16660 (submitting to 81X to fix workflows being run in IB):

This PR fixes a bug introduced in #16559. The logic inferring the track MVA selector names missed a check that the MVA selector is part of the iteration sequence. This omission lead errors for tracking eras without MVA selection (trackingLowPU, trackingPhase1PU70, trackingPhase2PU140) in trackingOnly workflows. The check is added here.

Tested in CMSSW_8_1_X_2016-11-15-2300, no changes expected in non-trackingOnly workflows, or in trackingOnly workflows with run2 or trackingPhase1 tracking.

@rovere @VinInn

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_8_1_X.

It involves the following packages:

RecoTracker/IterativeTracking
Validation/RecoTrack

@cvuosalo, @dmitrijus, @cmsbuild, @slava77, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @GiacomoSguazzoni, @rovere, @VinInn, @mschrode, @wmtford, @gpetruc, @dgulhan this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[makortel]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16386/console

[makortel]

type bugfix

[makortel]

backport of #16660

[cmsbuild]

+1
Tested at: cc7fc5a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16661/16386/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16661/16386/summary.html

Alternative comparison was/were failed for workflow(s):
25202.0
1001.0

[cmsbuild]

Pull request #16661 was updated. @cvuosalo, @dmitrijus, @cmsbuild, @slava77, @vanbesien, @davidlange6 can you please check and sign again.

[makortel]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16543/console

[dmitrijus]

+1

[cvuosalo]

urgent

[cmsbuild]

+1
Tested at: 18b2b56
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16661/16543/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16661/16543/summary.html

Alternative comparison was/were failed for workflow(s):
9.0

[cvuosalo]

+1

For #16661 18b2b56

Fix a bug in MVA selection for tracking-only workflows. There should be no change in monitored quantities for other workflows.

#16660 is the 90X version of this PR, and it has already been approved.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_1_X_2016-11-21-2300 show no significant differences, as expected. Expanded configs were checked for #16660, and they show that only tracking-only workflows are changed as expected.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

[davidlange6]

+1