New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements for upgrade matrix #16665
Conversation
A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_9_0_X. It involves the following packages: Configuration/Generator @perrozzi, @thuer, @fabozzi, @cmsbuild, @srimanob, @govoni, @hengne, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
@cmsbuild please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
+1 |
I think that there is a problem in this PR
vs
note that the two come out with different beam spots. I think the rule should be in place that the same number should give the same workflow. Please fix. |
@lgray I think we need to port the beamspot-related lines from relval_upgrade to relval_2023 |
which is the right BS for the 14TeV samples? |
Hi, I am digging myself out from CMS week and timing.. Yes, use the "VtxSmearedHLLHC14TeV" beamspot. There is a change in the lorentz boost of the bunches, as @slava77 is talking about. |
I would prefer that we convert of all 13 TeV samples in the upgrade workflows. There should only be 14 TeV, they should also all be pythia8 now. @kpedro88 is this correct? |
@lgray we can't remove 13TeV workflows from the upgrade fragment list, because it's also used for 2017 etc. Everything should be pythia8 now. If there's some specific workflow that's missing a 14TeV version, it can be added (I did some recently, but maybe not all.) |
Ok, there are definitely a few we'll add then. |
@kpedro88 , could this PR be the reason of these errors in new 2361* workflows? |
#16682 fixes that |
Changes:
I tested 4) by adding a bunch of fake upgrade keys and observed the intended numbering:
attn: @slava77, @boudoul, @makortel
This may cause some "missing matrix maps" when merged...
will be backported to 81X