Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[90X] Re-add eventSetupPathKey to ALCARECOLumiPixels #16686

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Nov 18, 2016

This PR allows the possibility to steer the selection of the trigger bits populating the ALCARECOLumiPixels ALCARECO via TriggerBit stored in DB.

This should solve the issue with the problematic version of the trigger:
AlCa_PAL1MinimumBiasHF_OR_SinglePixelTrack_v1
creating events with event content not manageable by the ALCARECOLumiPixels reported in: HN link by filtering out the offending trigger with an appropriate DB payload.

fwd-port of #16684

@mmusich
Copy link
Contributor Author

mmusich commented Nov 18, 2016

please test

@cmsbuild cmsbuild added this to the Next CMSSW_9_0_X milestone Nov 18, 2016
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 18, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16472/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_9_0_X.

It involves the following packages:

Calibration/TkAlCaRecoProducers

@ghellwig, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @threus, @tocheng this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@mmusich
Copy link
Contributor Author

mmusich commented Nov 18, 2016

please test

@cmsbuild
Copy link
Contributor

-1

Tested at: e263fe6

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16686/16472/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
21234.0 step2

runTheMatrix-results/21234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D4_GenSimHLBeamSpotFull+DigiFull_2023D4+RecoFullGlobal_2023D4+HARVESTFullGlobal_2023D4/step2_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D4_GenSimHLBeamSpotFull+DigiFull_2023D4+RecoFullGlobal_2023D4+HARVESTFullGlobal_2023D4.log
23234.0 step2
runTheMatrix-results/23234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D5_GenSimHLBeamSpotFull+DigiFull_2023D5+RecoFullGlobal_2023D5+HARVESTFullGlobal_2023D5/step2_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D5_GenSimHLBeamSpotFull+DigiFull_2023D5+RecoFullGlobal_2023D5+HARVESTFullGlobal_2023D5.log

@cmsbuild
Copy link
Contributor

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@mmusich
Copy link
Contributor Author

mmusich commented Nov 18, 2016

----- Begin Fatal Exception 18-Nov-2016 16:58:38 CET-----------------------
An exception of category 'StdException' occurred while
   [0] Processing run: 1 lumi: 1 event: 8
   [1] Running path 'L1simulation_step'
   [2] Calling event method for module HGCalTriggerDigiProducer/'hgcalTriggerPrimitiveDigiProducer'
   [3] Calling method for unscheduled module HGCalTriggerDigiProducer/'hgcalTriggerPrimitiveDigiProducer'
Exception Message:
A std::exception was thrown.
_Map_base::at
----- End Fatal Exception -------------------------------------------------

is not related to this PR

@cmsbuild
Copy link
Contributor

Pull request #16686 was updated. @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Nov 21, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 21, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16509/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@mmusich
Copy link
Contributor Author

mmusich commented Nov 21, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ad86fed into cms-sw:CMSSW_9_0_X Nov 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants