New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[90X] Re-add eventSetupPathKey to ALCARECOLumiPixels #16686
[90X] Re-add eventSetupPathKey to ALCARECOLumiPixels #16686
Conversation
please test |
The tests are being triggered in jenkins. |
A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_9_0_X. It involves the following packages: Calibration/TkAlCaRecoProducers @ghellwig, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
please test |
-1 Tested at: e263fe6 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following worklfows: runTheMatrix-results/21234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D4_GenSimHLBeamSpotFull+DigiFull_2023D4+RecoFullGlobal_2023D4+HARVESTFullGlobal_2023D4/step2_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D4_GenSimHLBeamSpotFull+DigiFull_2023D4+RecoFullGlobal_2023D4+HARVESTFullGlobal_2023D4.log23234.0 step2 runTheMatrix-results/23234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D5_GenSimHLBeamSpotFull+DigiFull_2023D5+RecoFullGlobal_2023D5+HARVESTFullGlobal_2023D5/step2_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D5_GenSimHLBeamSpotFull+DigiFull_2023D5+RecoFullGlobal_2023D5+HARVESTFullGlobal_2023D5.log |
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
is not related to this PR |
e263fe6
to
e4baa43
Compare
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
+1 |
This PR allows the possibility to steer the selection of the trigger bits populating the
ALCARECOLumiPixels
ALCARECO via TriggerBit stored in DB.This should solve the issue with the problematic version of the trigger:
AlCa_PAL1MinimumBiasHF_OR_SinglePixelTrack_v1
creating events with event content not manageable by the
ALCARECOLumiPixels
reported in: HN link by filtering out the offending trigger with an appropriate DB payload.fwd-port of #16684