New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Phase2 memory corruption (81X) #16697
Conversation
A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_8_1_X. It involves the following packages: RecoParticleFlow/PFTracking @cmsbuild, @cvuosalo, @slava77, @monttj, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
@cmsbuild please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
+1 |
+1 Fixing two memory corruption problems seen in Phase 2 testing. #16696 is the 90X version of this PR, and it has already been approved. The code changes are satisfactory. Jenkins tests against baseline CMSSW_8_1_X_2016-11-19-1100 show no significant differences, except in Phase 2 workflows, where there are numerous tiny, insignificant differences. Further tests for #16696 show that only Phase 2 workflows show differences, and these differences are very tiny and insignificant. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
Backport of #16696