New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[90X] Add Phase-I Cosmics #16709
[90X] Add Phase-I Cosmics #16709
Conversation
please test |
The tests are being triggered in jenkins. |
A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_9_0_X. It involves the following packages: Configuration/AlCa @ghellwig, @civanch, @dmitrijus, @cvuosalo, @arunhep, @franzoni, @mdhildreth, @fabozzi, @cmsbuild, @srimanob, @cerminar, @slava77, @mmusich, @vanbesien, @hengne, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
Comparison job queued. |
+1 |
@mmusich: This PR needs to be re-based. |
Also requires changing phase0 paths to separate offline and offline cosmics in harvesting.
83bc4f9
to
c75c4d0
Compare
Pull request #16709 was updated. @ghellwig, @civanch, @dmitrijus, @cvuosalo, @arunhep, @franzoni, @mdhildreth, @fabozzi, @cmsbuild, @srimanob, @cerminar, @slava77, @mmusich, @vanbesien, @hengne, @davidlange6 can you please check and sign again. |
@cmsbuild, please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
I am not sure it has anything to do with the proposed changes |
Comparison is ready Alternative comparison was/were failed for workflow(s): |
hi all - changes here look straightforward - please complain about any further issues during the ORP today. thanks |
why does "add phase-1 cosmics" affect regular pp workflows in 2017 and 2023 setups? |
ah, looks like the tests included other PRs |
This PR attempts to add a new cosmics simulation workflow using phase-I 2017 detector.
In order to consume cosmics reconstruction-tailored conditions a new autoCond Global Tag is added.
To address comments occurring during the review, appropriate commits were included to handle Hcal 2017 reconstruction with cosmics data and propagate to this wf the new phase-I pixel DQM.
On Hcal side (thanks @kpedro88):
readoutFrameSize
and forwarding through ZS algos accordinglyOn DQM side (thanks @schneiml):
config, since it is needed for Phase1.
Fwd-port of #16343