Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[90X] Add Phase-I Cosmics #16709

Merged
merged 12 commits into from Nov 22, 2016
Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Nov 21, 2016

This PR attempts to add a new cosmics simulation workflow using phase-I 2017 detector.
In order to consume cosmics reconstruction-tailored conditions a new autoCond Global Tag is added.
To address comments occurring during the review, appropriate commits were included to handle Hcal 2017 reconstruction with cosmics data and propagate to this wf the new phase-I pixel DQM.
On Hcal side (thanks @kpedro88):

  • Increased flexibility of HCAL cosmic setup by applying cosmic-specific settings to cloned modules and then assembling sequences for 2017 and pre-2017 separately
  • Updated HCAL NZS sequence for 2017 HF and HE changes (can be used in cosmic runs)
  • Modified size of simulated QIE10DigiCollection to be 4 samples instead of default 10, by accessing sim parameter readoutFrameSize and forwarding through ZS algos accordingly

On DQM side (thanks @schneiml):

  • Add a special cosmics sequence to the PixelPhase1 DQM config
  • Enable it for the phase1pixel era in the general Pixel offline DQM config
  • Add a special cosmics sequence for harvesting to the Pixel offline DQM
    config, since it is needed for Phase1.

Fwd-port of #16343

@mmusich
Copy link
Contributor Author

mmusich commented Nov 21, 2016

please test

@cmsbuild cmsbuild added this to the Next CMSSW_9_0_X milestone Nov 21, 2016
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 21, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16515/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_9_0_X.

It involves the following packages:

Configuration/AlCa
Configuration/PyReleaseValidation
DQM/SiPixelCommon
DQM/SiPixelPhase1Config
DQMOffline/Configuration
RecoLocalCalo/Configuration
SimCalorimetry/HcalSimProducers
SimCalorimetry/HcalZeroSuppressionProducers

@ghellwig, @civanch, @dmitrijus, @cvuosalo, @arunhep, @franzoni, @mdhildreth, @fabozzi, @cmsbuild, @srimanob, @cerminar, @slava77, @mmusich, @vanbesien, @hengne, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @hdelanno, @makortel, @felicepantaleo, @tocheng, @Martin-Grunewald, @fioriNTU, @idebruyn, @mariadalfonso, @threus, @rociovilar this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@mmusich
Copy link
Contributor Author

mmusich commented Nov 21, 2016

+1

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

@mmusich: This PR needs to be re-based.

@cmsbuild
Copy link
Contributor

Pull request #16709 was updated. @ghellwig, @civanch, @dmitrijus, @cvuosalo, @arunhep, @franzoni, @mdhildreth, @fabozzi, @cmsbuild, @srimanob, @cerminar, @slava77, @mmusich, @vanbesien, @hengne, @davidlange6 can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Nov 22, 2016

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 22, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16531/console

@cmsbuild
Copy link
Contributor

-1

Tested at: c75c4d0

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
861258a
9a2c793
ad86fed
dc8fe05
7627ada
6218fc9
a06e4a1
b9ab825
3aaed28
53d73a2
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16709/16531/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16709/16531/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16709/16531/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test TestFWCoreConcurrencyDriver had ERRORS

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
861258a
9a2c793
ad86fed
dc8fe05
7627ada
6218fc9
a06e4a1
b9ab825
3aaed28
53d73a2
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16709/16531/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16709/16531/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@mmusich
Copy link
Contributor Author

mmusich commented Nov 22, 2016

MessageLogger Summary

Severity    # Occurrences   Total Occurrences
--------    -------------   -----------------

Failure cmsRun streamGrapher_stallMonitor_cfg.py: status 84
status = 21504

---> test TestFWCoreConcurrencyDriver had ERRORS

I am not sure it has anything to do with the proposed changes

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16709/16531/summary.html

Alternative comparison was/were failed for workflow(s):
23234.0

@davidlange6
Copy link
Contributor

hi all - changes here look straightforward - please complain about any further issues during the ORP today. thanks

@slava77
Copy link
Contributor

slava77 commented Nov 22, 2016

why does "add phase-1 cosmics" affect regular pp workflows in 2017 and 2023 setups?

@slava77
Copy link
Contributor

slava77 commented Nov 22, 2016

ah, looks like the tests included other PRs

@davidlange6 davidlange6 merged commit 8063014 into cms-sw:CMSSW_9_0_X Nov 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants