Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make HLTPrescaler a stream filter with a global cache accounting #1672

Merged
merged 2 commits into from Dec 5, 2013
Merged

Make HLTPrescaler a stream filter with a global cache accounting #1672

merged 2 commits into from Dec 5, 2013

Conversation

Martin-Grunewald
Copy link
Contributor

Make HLTPrescaler a stream filter with a global cache accounting

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2013

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for CMSSW_7_0_X.

Make HLTPrescaler a stream filter with a global cache accounting

It involves the following packages:

HLTrigger/HLTcore

@Martin-Grunewald, @perrotta, @cmsbuild, @nclopezo, @fwyzard can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@Martin-Grunewald
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2013

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

Dr15Jones
Dr15Jones reviewed Dec 4, 2013
View reviewed changes
HLTrigger/HLTcore/plugins/SealModule.cc
@@ -12,7 +12,7 @@
#include "HLTrigger/HLTcore/interface/TriggerSummaryProducerRAW.h"
#include "HLTrigger/HLTcore/interface/HLTPrescaleRecorder.h"

DEFINE_FWK_MODULE(HLTPrescaler);
// DEFINE_FWK_MODULE(HLTPrescaler);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably best to remove the comment all together.

@Dr15Jones
Copy link
Contributor

Looks good to me. Nice job!

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2013

Pull request #1672 was updated. @Martin-Grunewald, @perrotta, @cmsbuild, @nclopezo, @fwyzard can you please check and sign again.

@Martin-Grunewald
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2013

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2013

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1672/1593/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2013

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

nclopezo added a commit that referenced this pull request Dec 5, 2013
@nclopezo
Merge pull request #1672 from Martin-Grunewald/HLTPrescaler
48bd9b5 
Make HLTPrescaler a stream filter with a global cache accounting
@nclopezo nclopezo merged commit 48bd9b5 into cms-sw:CMSSW_7_0_X Dec 5, 2013
@Martin-Grunewald Martin-Grunewald deleted the HLTPrescaler branch December 5, 2013 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fully-signed hlt-approved tests-approved
Projects
None yet
Milestone
CMSSW_7_0_0_pre10
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Martin-Grunewald @cmsbuild @Dr15Jones @nclopezo