Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in the name of GlobalTrackingRegionFromBeamSpotEDProducer #16788

Merged
merged 1 commit into from Nov 29, 2016

Conversation

makortel
Copy link
Contributor

This PR fixes a typo of an EDProducer in a typedef introduced in #16635 (Trackin -> Tracking).

Tested in CMSSW_9_0_X_2016-11-24-2300, no changes expected.

@rovere @VinInn @mtosi

@cmsbuild cmsbuild added this to the Next CMSSW_9_0_X milestone Nov 29, 2016
@makortel
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 29, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16645/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_9_0_X.

It involves the following packages:

RecoTracker/TkTrackingRegions

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @mschrode, @gpetruc, @dgulhan this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@makortel
Copy link
Contributor Author

I believe this fix would be useful to have in 900pre1 if possible, as to my understanding HLT is planning to import module configurations to ConfDB from pre1.

@mtosi

@makortel
Copy link
Contributor Author

type bugfix

@davidlange6
Copy link
Contributor

just renaming an unused module..

@davidlange6 davidlange6 merged commit ea0591f into cms-sw:CMSSW_9_0_X Nov 29, 2016
@makortel
Copy link
Contributor Author

GlobalTrackin(g)RegionFromBeamSpotEDProducer is used e.g. here RecoTracker/IterativeTracking/python/InitialStep_cff.py. The C++ type does not show up elsewhere by git grep because all uses import the fillDescriptions-generated _cfi.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16788/16645/summary.html

The workflows 1003.0, 1001.0, 1000.0, 140.53, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

@slava77
Copy link
Contributor

slava77 commented Nov 29, 2016

Looks like this holds a record for the fastest merged PR in the reco category, only 5 minutes.

@makortel makortel deleted the fixTrackingRegionTypo branch February 12, 2018 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants