Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update RECO & SIM phase-1 geometry (9_0_X) #16804

Conversation

franzoni
Copy link

Summary of changes in Global Tags

RunII simulation

  • PhaseI realistic scenario : 81X_upgrade2017_realistic_v25 as 81X_upgrade2017_realistic_v26 with the following changes:

    • RECO geom: un-do the assignment of passive material outside the TK volume to the last layer of TK
    • SIM geom: Fix overlaps in Pixel support structure. Subtraction with Union solid replacement in ES support structure (no changes in sensitive volumes) . Pixel support structure material density has been corrected to compensate for the (very minimal) shape changes.
  • PhaseI design scenario : 81X_upgrade2017_design_IdealBS_v9 as 81X_upgrade2017_design_IdealBS_v10 with the following changes:

    • RECO geom: un-do the assignment of passive material outside the TK volume to the last layer of TK
    • SIM geom: Fix overlaps in Pixel support structure. Subtraction with Union solid replacement in ES support structure (no changes in sensitive volumes) . Pixel support structure material density has been corrected to compensate for the (very minimal) shape changes.
  • PhaseI cosmics scenario : 81X_upgrade2017cosmics_realistic_peak_v8 as 81X_upgrade2017cosmics_realistic_peak_v9 with the following changes:

    • RECO geom: un-do the assignment of passive material outside the TK volume to the last layer of TK
    • SIM geom: Fix overlaps in Pixel support structure. Subtraction with Union solid replacement in ES support structure (no changes in sensitive volumes) . Pixel support structure material density has been corrected to compensate for the (very minimal) shape changes.

… XMLFILE_Geometry_81Y - details yet to be clarified) not to assign the passive material external to TK to the last TK layer
@franzoni
Copy link
Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 29, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16667/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @franzoni (Giovanni Franzoni) for CMSSW_9_0_X.

It involves the following packages:

Configuration/AlCa

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @ghellwig, @tocheng this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@franzoni
Copy link
Author

the PR tests will assess the changes in RECO geometry
since not re-doing GEN-SIM, the differences between XMLFILE_Geometry_81YV15_Extended2017_mc XMLFILE_Geometry_81YV16_Extended2017_mc will need be assessed separately

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16804/16667/summary.html

The workflows 1003.0, 1001.0, 1000.0, 140.53, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

@mmusich
Copy link
Contributor

mmusich commented Dec 1, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9489748 into cms-sw:CMSSW_9_0_X Dec 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants