Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix L1 fat event filters (80x bis) #16806

Conversation

rekovic
Copy link
Contributor

@rekovic rekovic commented Nov 29, 2016

80x version of 81x #16782, and of 90x #16799.

This is a replacement for 80x #16765
as it contains the addendum (cherry-picked 0537ca8 from #16782)

For completion, here is the original header:

Fixes for two filters used to select L1T "fat events", to use of the 64-bit event number from TCDS FED word 11 (https://twiki.cern.ch/twiki/bin/viewauth/CMS/TcdsEventRecord#TCDS_Data_Block_Definition_curre) instead of the 24-bit event number from common DAQ header.
In the case of HLTL1NumberFilter, use of the common DAQ header (ie. existing functionality) is maintained as default.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rekovic for CMSSW_8_0_X.

It involves the following packages:

EventFilter/L1TRawToDigi
HLTrigger/special

@perrotta, @cmsbuild, @silviodonato, @Martin-Grunewald, @rekovic, @fwyzard, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @kreczko this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@rekovic
Copy link
Contributor Author

rekovic commented Nov 29, 2016

please test

@rekovic
Copy link
Contributor Author

rekovic commented Nov 29, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 29, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16671/console

@fwyzard
Copy link
Contributor

fwyzard commented Nov 29, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Pull request #16806 was updated. @perrotta, @cmsbuild, @silviodonato, @cvuosalo, @fwyzard, @emeschi, @Martin-Grunewald, @rekovic, @slava77, @mommsen, @mulhearn, @davidlange6 can you please check and sign again.

@rekovic
Copy link
Contributor Author

rekovic commented Jan 30, 2017

Two above commits ( 8fb42dc and 8574895) cherry-picked from the merged 90x #17082.
These commits address comment of David #16806 (comment) .

@rekovic
Copy link
Contributor Author

rekovic commented Jan 30, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 30, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17492/console Started: 2017/01/30 11:21

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@rekovic
Copy link
Contributor Author

rekovic commented Jan 30, 2017

+1

@cmsbuild
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants