DQM: fix clang warnings about missing override keyword #16809
Conversation
|
A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_9_0_X. It involves the following packages: DQM/BeamMonitor @perrotta, @cmsbuild, @silviodonato, @dmitrijus, @Martin-Grunewald, @fwyzard, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
please test |
|
The tests are being triggered in jenkins. |
|
Pull request #16809 was updated. @perrotta, @cmsbuild, @silviodonato, @dmitrijus, @Martin-Grunewald, @fwyzard, @vanbesien, @davidlange6 can you please check and sign again. |
|
@Dr15Jones I missed one file. Please start test again. |
| @@ -340,7 +340,7 @@ void SiStripFEDCheckPlugin::bookHistograms(DQMStore::IBooker & ibooker , const e | |||
|
|
|||
| // ------------ method called once each run just after ending the event loop ------------ | |||
| void | |||
| SiStripFEDCheckPlugin::endRun() | |||
| SiStripFEDCheckPlugin::endRun(edm::Run const&, edm::EventSetup const&) | |||
There was a problem hiding this comment.
This changes the signaure of the function so changes the behavior (since the framework will now actually call the function).
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready The workflows 1003.0, 1001.0, 1000.0, 140.53, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons |
|
+1 |
This adds the keyword override where needed to remove clang warning:
overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
In 4 cases the function is changed to add unused parameters so the function parameters matches the overridden function parameters.