Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FSimTrack::daughters() returns empty vector if no endvertex is present #1683

Merged
merged 2 commits into from Dec 6, 2013
Merged

FSimTrack::daughters() returns empty vector if no endvertex is present #1683

merged 2 commits into from Dec 6, 2013

Conversation

lveldere
Copy link
Contributor

@lveldere lveldere commented Dec 5, 2013

PFSimParticleProducer depends on this behaviour

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2013

A new Pull Request was created by @lveldere for CMSSW_7_0_X.

FSimTrack::daughters() returns empty vector if no endvertex is present

It involves the following packages:

FastSimulation/Event

@cmsbuild, @nclopezo, @giamman, @lveldere can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@lveldere
Copy link
Contributor Author

lveldere commented Dec 5, 2013

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2013

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2013

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1683/1604/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2013

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

nclopezo added a commit that referenced this pull request Dec 6, 2013
@nclopezo
Merge pull request #1683 from lveldere/fsimtrack-fix-daughters
b41c2d8 
FSimTrack::daughters() returns empty vector if no endvertex is present
@nclopezo nclopezo merged commit b41c2d8 into cms-sw:CMSSW_7_0_X Dec 6, 2013
@lveldere lveldere deleted the fsimtrack-fix-daughters branch March 19, 2014 16:03
ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
@aledegano
Merge pull request cms-sw#1683 from cms-sw/revert-1682-root_patches_7…
fc92291 
…6XStable

Revert "Include recent fixes from 6.02.patches root branch."
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fastsim-approved fully-signed tests-approved
Projects
None yet
Milestone
CMSSW_7_0_0_pre10
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lveldere @cmsbuild @nclopezo