Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HGCal 2D Layer Clusters #16840

Merged
merged 16 commits into from Dec 7, 2016
Merged

Conversation

lgray
Copy link
Contributor

@lgray lgray commented Dec 2, 2016

Forward port of #16813.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2016

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_9_0_X.

It involves the following packages:

RecoLocalCalo/Configuration
RecoLocalCalo/HGCalRecAlgos
RecoLocalCalo/HGCalRecProducers

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@vandreev11, @sethzenz, @kpedro88, @argiro, @cseez, @pfs this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@lgray
Copy link
Contributor Author

lgray commented Dec 2, 2016

@cvuosalo I will deal with the code comments soon. Starting this PR so you may continue.

@lgray
Copy link
Contributor Author

lgray commented Dec 2, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16735/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2016

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2016

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16840/16735/summary.html

The workflows 1003.0, 1001.0, 1000.0, 140.53, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2016

Pull request #16840 was updated. @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please check and sign again.

@lgray
Copy link
Contributor Author

lgray commented Dec 7, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16824/console Started: 2016/12/07 08:53

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2016

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2016

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16840/16824/summary.html

The workflows 1003.0, 1001.0, 1000.0, 140.53, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

@cvuosalo
Copy link
Contributor

cvuosalo commented Dec 7, 2016

+1

For #16840 66f5c81

Adds a Phase 2 HGCal clustering algorithm, which does not run by default in standard workflows. There should be no change in monitored quantities.

#16813 is the 81X version of this PR, and it has already been approved, though it may never be merged since 90X is now the target for Phase 2 development.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_9_0_X_2016-12-06-1100 show no significant differences, as expected, except for a glitch for workflow 136.731 that is unrelated to this PR. Tests of the new clustering are described in #16813 and show no problems.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 99c5d11 into cms-sw:CMSSW_9_0_X Dec 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants