Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PixelTracksForL3Isolation configurations and IsolationRegionAroundL3Muon as obsolete #16863

Merged

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Dec 5, 2016

While migrating PixelTrackProducer to the new seeding framework (from #16635), I encountered *TracksForL3Isolation_cf*.py set of configuration files and IsolationRegionAroundL3Muon TrackingRegionProducer that seem to be currently unused. I'm asking if they are obsolete and can be removed, or still need to be maintained? (I'm more interested in the configs than the region producer). The files were confirmed to be obsolete (see message below #16863 (comment)).

The commit shows the exact set of files.

Tested in CMSSW_9_0_X_2016-12-02-1100, no changes expected.

@slava77 @cvuosalo @rovere @VinInn @mtosi

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2016

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_9_0_X.

It involves the following packages:

RecoMuon/L3MuonIsolationProducer

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@bellan, @abbiendi, @jhgoh, @calderona, @HuguesBrun, @battibass, @trocino, @bachtis, @rociovilar this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@makortel
Copy link
Contributor Author

makortel commented Dec 5, 2016

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16775/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2016

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2016

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16863/16775/summary.html

The workflows 1003.0, 1001.0, 1000.0, 140.53, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

@slava77
Copy link
Contributor

slava77 commented Dec 5, 2016

@jhgoh, @calderona, @HuguesBrun, @battibass please confirm that it's OK to remove these muon HLT modules

@HuguesBrun
Copy link
Contributor

Hello @slava77 ,
After double check with the muon HLT conveners (@sarafiorendi and @BenjaminRS) we confirm that this code is not used anymore in muon reconstruction at HLT. It was used in run 1 but we switched to the regional iterative tracking so we do not see any reason for maintaining this piece of code

@makortel
Copy link
Contributor Author

makortel commented Dec 6, 2016

@HuguesBrun @sarafiorendi @BenjaminRS Thanks for the confirmation, I'll modify the PR title and description accordingly.

@makortel makortel changed the title [RFC] Are PixelTracksForL3Isolation configurations and IsolationRegionAroundL3Muon obsolete? Remove PixelTracksForL3Isolation configurations and IsolationRegionAroundL3Muon as obsolete Dec 6, 2016
@slava77
Copy link
Contributor

slava77 commented Dec 6, 2016

+1

for #16863 de47aa4

  • removal of obsolete code (not present in tested workflows)
  • jenkins tests pass

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 0177aec into cms-sw:CMSSW_9_0_X Dec 7, 2016
@makortel makortel deleted the removePixelTracksForL3Isolation branch February 12, 2018 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants