Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leak in FastTSGFromPropagation #16877

Conversation

Dr15Jones
Copy link
Contributor

Leak found by valgrind.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2016

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_9_0_X.

It involves the following packages:

FastSimulation/Muons

@ssekmen, @lveldere, @civanch, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @matt-komm this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@Dr15Jones
Copy link
Contributor Author

As far as I can tell the build virtual function takes a const pointer and the underlying implementation clones the hit.

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16793/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2016

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2016

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16877/16793/summary.html

The workflows 1003.0, 1001.0, 1000.0, 140.53, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

@davidlange6 davidlange6 merged commit 53705d4 into cms-sw:CMSSW_9_0_X Dec 7, 2016
@Dr15Jones Dr15Jones deleted the fixMemoryLeakFastTSGFromPropagation branch December 13, 2016 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants