remove IN_DICTBUILD with __CLING__ to control the visibility of standard math vs sse #16891
Conversation
|
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for CMSSW_9_0_X. It involves the following packages: DataFormats/GeometrySurface @civanch, @cvuosalo, @mdhildreth, @monttj, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
please test |
|
The tests are being triggered in jenkins. |
|
-1 Tested at: 24556e3 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see the results of the tests here: I found follow errors while testing this PR Failed tests: Build
I found an error when building: >> Compiling /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2016-12-06-1100/src/RecoTracker/TkMSParametrization/src/MSLayer.cc
>> Compiling /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2016-12-06-1100/src/RecoTracker/TkMSParametrization/src/MSLayersKeeperX0DetLayer.cc
>> Compiling /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2016-12-06-1100/src/RecoTracker/TkMSParametrization/src/MSLayersAtAngle.cc
>> Compiling /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2016-12-06-1100/src/RecoTracker/TkMSParametrization/src/MultipleScatteringParametrisation.cc
In file included from input_line_9:45:
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2016-12-06-1100/src/RecoTracker/TkTrackingRegions/interface/TrackingRegion.h:46:33: error: no type named 'ConstRecHitPointer' in 'SeedingLayerSetsHits'
typedef SeedingLayerSetsHits::ConstRecHitPointer Hit;
~~~~~~~~~~~~~~~~~~~~~~^
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2016-12-06-1100/src/RecoTracker/TkTrackingRegions/interface/TrackingRegion.h:47:33: error: no type named 'Hits' in 'SeedingLayerSetsHits'
typedef SeedingLayerSetsHits::Hits Hits;
~~~~~~~~~~~~~~~~~~~~~~^
The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-rejected
and removed
comparison-pending
tests-started
labels
…6.08 IBs include #16890 changes here
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-notrun
tests-rejected
labels
|
Pull request #16891 was updated. @civanch, @cvuosalo, @mdhildreth, @monttj, @cmsbuild, @slava77, @davidlange6 can you please check and sign again. |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready The workflows 1003.0, 1001.0, 1000.0, 140.53, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons |
|
Jenkins results are showing a few odd fluctuations. Does this PR subtly change math behavior? Workflow 10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017 shows:
Workflow 25202.0_TTbar_13 shows: |
|
On 12/7/16 2:44 PM, Carl Vuosalo wrote:
Jenkins results are showing a few odd fluctuations. Does this PR subtly
change math behavior?
Workflow 10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017 shows:
tau
<https://cloud.githubusercontent.com/assets/5736159/20989935/3ecd7c4a-bc9c-11e6-9322-27191ec3484b.png>
Workflow 25202.0_TTbar_13 shows:
met
<https://cloud.githubusercontent.com/assets/5736159/20989953/4f4c0eec-bc9c-11e6-9c70-1d55d3c5ac04.png>
jenkins used CMSSW_9_0_X_2016-12-07-0000
this PR is based on
CMSSW_9_0_X_2016-12-07-1100
at least a part of the diffs is from
CMSSW_9_0_X_2016-12-07-0000..CMSSW_9_0_X_2016-12-07-1100
rerun the tests maybe?
…
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#16891 (comment)>, or
mute the thread
<https://github.com/notifications/unsubscribe-auth/AEdcbsuFbrnbobgz9QIbUJZB-LSZMHnXks5rFza3gaJpZM4LGWUq>.
|
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
cmsbuild
added
comparison-pending
tests-pending
tests-started
and removed
comparison-available
tests-approved
tests-pending
labels
|
-1 Tested at: 5cd67ee You can see the results of the tests here: I found follow errors while testing this PR Failed tests: UnitTests
I found errors in the following unit tests: ---> test testRecoMETMETProducers had ERRORS |
|
Comparison job queued. |
|
Comparison is ready The workflows 1003.0, 1001.0, 1000.0, 140.53, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons |
|
+1 Replacing preprocessor directive The code changes are satisfactory, and Jenkins tests against baseline CMSSW_9_0_X_2016-12-07-2300 show no significant differences, as expected. The Jenkins tests have several problems that are not related to this PR. |
backport of #16440
As reported in #16291 , root sees inconsistents sse headers. This PR should avoid the use of internal IN_DICTBUILD and use
__CLING__