Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calibration/EcalAlCaRecoProducers: fix clang warnings #16985

Merged
merged 1 commit into from Dec 13, 2016
Merged

Calibration/EcalAlCaRecoProducers: fix clang warnings #16985

merged 1 commit into from Dec 13, 2016

Conversation

gartung
Copy link
Member

@gartung gartung commented Dec 12, 2016

because beginRun parameters were corrected to match base class to
fix clang warning hides overloaded virtual function [-Woverloaded-virtual]

@gartung
Calibration/EcalAlCaRecoProducers: fix clang warnings
3973344 
hides overloaded virtual function [-Woverloaded-virtual]
by removing unneeded declarations of functions that do
not override base class functions.
@cmsbuild cmsbuild added this to the Next CMSSW_9_0_X milestone Dec 12, 2016
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_9_0_X.

It involves the following packages:

Calibration/EcalAlCaRecoProducers

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @tocheng, @argiro this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@mmusich
Copy link
Contributor

mmusich commented Dec 13, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 13, 2016 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16987/console Started: 2016/12/13 07:33

@cmsbuild
Copy link
Contributor

+1
Tested at: 3973344
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16985/16987/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16985/16987/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • 20034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D7_GenSimHLBeamSpotFull14+DigiFull_2023D7+RecoFullGlobal_2023D7+HARVESTFullGlobal_2023D7
  • 23234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D8_GenSimHLBeamSpotFull14+DigiFull_2023D8+RecoFullGlobal_2023D8+HARVESTFullGlobal_2023D8

@mmusich
Copy link
Contributor

mmusich commented Dec 13, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9e45a69 into cms-sw:CMSSW_9_0_X Dec 13, 2016
@gartung gartung deleted the Calibration-EcalAlCaRecoProducers-fix-clang-warnings branch December 13, 2016 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-approved comparison-available fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_9_0_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gartung @cmsbuild @mmusich @davidlange6