Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix using unscheduled execution with a SubProcess #17064

Merged
merged 2 commits into from Dec 17, 2016

Conversation

Dr15Jones
Copy link
Contributor

Fixed the case where a module from a parent process is triggered by
a data request from a module in a SubProcess.

Fixed the case where a module from a parent process is triggered by
a data request from a module in a SubProcess.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_9_0_X.

It involves the following packages:

FWCore/Framework
FWCore/Integration

@cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit, @wmtan this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@Dr15Jones
Copy link
Contributor Author

please test

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 17, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17095/console Started: 2016/12/17 04:23

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

Now properly run the timer for modules from a parent process which
are run unscheduled because of a data request from a SubProcess.
@cmsbuild
Copy link
Contributor

Pull request #17064 was updated. @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please check and sign again.

@Dr15Jones
Copy link
Contributor Author

please abort

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 17, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17096/console Started: 2016/12/17 04:36

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Tested at: e47662b

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
75c2d6c
3126fe3
363e724
b5ab52a
744f9de
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17064/17096/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17064/17096/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17064/17096/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test DetectorDescriptionRegressionTestDOMCount had ERRORS

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
75c2d6c
3126fe3
363e724
b5ab52a
744f9de
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17064/17096/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17064/17096/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@Dr15Jones
Copy link
Contributor Author

The unit test failure is unrelated to this pull request.

@davidlange6
Copy link
Contributor

davidlange6 commented Dec 17, 2016 via email

@cmsbuild cmsbuild merged commit a9f67a8 into cms-sw:CMSSW_9_0_X Dec 17, 2016
@Dr15Jones Dr15Jones deleted the fixSubProcessUnscheduled branch January 3, 2017 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants