Bph reco update, jan 01 2017 #17111
Bph reco update, jan 01 2017 #17111
Conversation
- BPHDecayVertex - check for valid tracks in "validVertex" - use clone address as map key in "addV" - BPHPlusMinusCandidate - pass string by reference in "build" - BPHDecayMomentum - add pointer check in "getDaug"
- BPHKx0ToKPiBuilder
- misleading collection names changed
- BPHOniaToMuMuBuilder
- retrieve original reco::Candidate only once before loop
in "getOriginalCandidate"
- get track search lists from original onia candidates in "extractList"
- TestBPHSpecificDecay
- fix K name for Bu reconstruction in "analyze"
new function "getTrackSearchList"
- new parameter added to "getTrack" to retrieve the flag for the function actually used to get the reco::Track
- selection at kinematic fit level added - cosmetic: code realigned
- missing function implementation added
- cascade daughter retrieval added for composite daughters in "getComp"
- selection at kinematic fit level added in "getList"
- momentum from kinematic fit written on demand in "write"
|
A new Pull Request was created by @ronchese for CMSSW_9_0_X. It involves the following packages: HeavyFlavorAnalysis/RecoDecay @cmsbuild, @monttj, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
| @@ -172,6 +172,7 @@ class BPHWriteSpecificDecay: | |||
| const RefCountedKinematicParticle kinPart = ptr->currentParticle(); | |||
| const KinematicState kinStat = kinPart->currentState(); | |||
| cc.addUserFloat( "fitMass", kinStat.mass() ); | |||
| if ( writeMomentum ) | |||
There was a problem hiding this comment.
hi @ronchese - given the new if statement, line 176 should be indented further. Please update that line. Thanks
|
Pull request #17111 was updated. @cmsbuild, @monttj, @davidlange6 can you please check and sign again. |
a few bug fixes and new features
commit:
5e07f80
bug fixes in BPHDecayVertex, BPHPlusMinusCandidate, BPHDecayMomentum
commits:
3bf8600
e9a382a
new function in BPHDecayVertex and
bug fixes in BPHKx0ToKPiBuilder, BPHOniaToMuMuBuilder, TestBPHSpecificDecay
commit:
1f2e2c0
update of BPHTrackReference
commit:
1914d6c
update of BPHMultiSelect
commit:
aef2dde
update of BPHMultiSelect
commit:
d2243d1
update of BPHDecayMomentum
commit:
1f46beb
update of BPHOniaToMuMuBuilder
commit:
f2153a7
update of BPHWriteSpecificDecay