New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix exception message context information #17113
Fix exception message context information #17113
Conversation
If an exception occurred, the exception message context would contain two lines referring to the module on the originating path. This was from both the Worker and the Path printing module related information. Now the module info only comes from the Worker.
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_9_0_X. It involves the following packages: FWCore/Framework @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
please test |
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
-1 Tested at: 443ec2e You can see the results of the tests here: I found follow errors while testing this PR Failed tests: UnitTests
I found errors in the following unit tests: ---> test TestFWCoreFrameworkGlobalStreamOne had ERRORS |
Comparison job queued. |
please test |
The tests are being triggered in jenkins. |
The test failure has nothing to do with this pull request (the test is just poor and can randomly fail because of timing issues). |
-1 Tested at: 443ec2e You can see the results of the tests here: I found follow errors while testing this PR Failed tests: UnitTests
I found errors in the following unit tests: ---> test testRecoMETMETProducers had ERRORS |
Comparison job queued. |
the test failure is unrelated to this pull request |
If an exception occurred, the exception message context would contain
two lines referring to the module on the originating path. This was
from both the Worker and the Path printing module related information.
Now the module info only comes from the Worker.