Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception message context information #17113

Merged

Conversation

Dr15Jones
Copy link
Contributor

If an exception occurred, the exception message context would contain
two lines referring to the module on the originating path. This was
from both the Worker and the Path printing module related information.
Now the module info only comes from the Worker.

If an exception occurred, the exception message context would contain
two lines referring to the module on the originating path. This was
from both the Worker and the Path printing module related information.
Now the module info only comes from the Worker.
@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 4, 2017

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_9_0_X.

It involves the following packages:

FWCore/Framework

@cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit, @wmtan this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@Dr15Jones
Copy link
Contributor Author

please test

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 4, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17179/console Started: 2017/01/04 21:38

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 4, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 5, 2017

-1

Tested at: 443ec2e

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17113/17179/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test TestFWCoreFrameworkGlobalStreamOne had ERRORS

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 5, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 5, 2017

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 5, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17185/console Started: 2017/01/05 14:23

@Dr15Jones
Copy link
Contributor Author

The test failure has nothing to do with this pull request (the test is just poor and can randomly fail because of timing issues).

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 5, 2017

-1

Tested at: 443ec2e

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17113/17185/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test testRecoMETMETProducers had ERRORS

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 5, 2017

Comparison job queued.

@Dr15Jones
Copy link
Contributor Author

the test failure is unrelated to this pull request

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 5, 2017

@davidlange6 davidlange6 merged commit de1e210 into cms-sw:CMSSW_9_0_X Jan 7, 2017
@Dr15Jones Dr15Jones deleted the fixExceptionContextMessage branch January 12, 2017 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants