Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing HcalDeterministicFit::rCorrSiPM #17126

Merged
merged 1 commit into from Jan 7, 2017

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented Jan 6, 2017

The following error in blocking Clang builds:

RecoLocalCaloHcalRecAlgos/HcalDeterministicFit.o: In function calDeterministicFit::phase1Apply(HBHEChannelInfo const&, float&, float&) const':
RecoLocalCalo/HcalRecAlgos/src/HcalDeterministicFit.cc:(.text+0x583): undefined reference to calDeterministicFit::rCorrSiPM'
RecoLocalCalo/HcalRecAlgos/src/HcalDeterministicFit.cc:(.text+0x5a9): undefined reference to calDeterministicFit::rCorrSiPM'

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

The following error in blocking Clang builds:

    RecoLocalCaloHcalRecAlgos/HcalDeterministicFit.o: In function calDeterministicFit::phase1Apply(HBHEChannelInfo const&, float&, float&) const':
    RecoLocalCalo/HcalRecAlgos/src/HcalDeterministicFit.cc:(.text+0x583): undefined reference to calDeterministicFit::rCorrSiPM'
    RecoLocalCalo/HcalRecAlgos/src/HcalDeterministicFit.cc:(.text+0x5a9): undefined reference to calDeterministicFit::rCorrSiPM'

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2017

A new Pull Request was created by @davidlt for CMSSW_9_0_X.

It involves the following packages:

RecoLocalCalo/HcalRecAlgos

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@mariadalfonso, @argiro this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@slava77
Copy link
Contributor

slava77 commented Jan 6, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17198/console Started: 2017/01/06 15:57

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2017

@slava77
Copy link
Contributor

slava77 commented Jan 6, 2017

+1

for #17126 f99688e

  • technical change
  • jenkins tests pass

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 31b8163 into cms-sw:CMSSW_9_0_X Jan 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants