Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of tmpnam in generators #17135

Merged
merged 1 commit into from Jan 10, 2017

Conversation

lgray
Copy link
Contributor

@lgray lgray commented Jan 9, 2017

Removes a compiler warning in gcc620/530 since tmpnam is not threadsafe.

@lgray
Copy link
Contributor Author

lgray commented Jan 9, 2017

@cmsbuild please test

@cmsbuild cmsbuild added this to the Next CMSSW_9_0_X milestone Jan 9, 2017
@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17215/console Started: 2017/01/09 20:00

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2017

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_9_0_X.

It involves the following packages:

GeneratorInterface/EvtGenInterface

@cmsbuild, @govoni, @perrozzi, @thuer, @davidlange6 can you please review it and eventually sign? Thanks.
@agrohsje, @mkirsano this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2017

@perrozzi
Copy link
Contributor

perrozzi commented Jan 9, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ca5c5a2 into cms-sw:CMSSW_9_0_X Jan 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants