Force untracked parameters for modules into Registry #17137
Conversation
If an input file contained the same PSet ID (because of identical tracked parameters) as a module in a process, the untracked parameters for the module are not available in the Registry. This caused problems with the deleteEarly system which uses an untracked parameter. We now force the PSet for a module to be injected into the Registry.
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_9_0_X. It involves the following packages: FWCore/Framework @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
please test |
|
+1 |
|
The tests are being triggered in jenkins. |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
|
-1 Tested at: d9359e3 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: Build
I found an error when building: gmake[1]: Target 'PostBuild' not remade because of errors. gmake[1]: Leaving directory '/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-01-09-1100' config/SCRAM/GMake/Makefile.rules:2008: recipe for target 'src' failed gmake: *** [src] Error 2 gmake: Target 'all' not remade because of errors. gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2 |
|
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-rejected
and removed
comparison-pending
tests-started
labels
|
please test |
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-notrun
tests-rejected
labels
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
+1 |
|
+1
On 10 Jan 2017, at 14:23, cmsbuild <notifications@github.com<mailto:notifications@github.com>> wrote:
Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17137/17224/summary.html
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#17137 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AEzyw-IEMqjCcAyvuENzAJCzvqqrCD_2ks5rQvmPgaJpZM4Leyxc>.
|
If an input file contained the same PSet ID (because of identical
tracked parameters) as a module in a process, the untracked
parameters for the module are not available in the Registry. This
caused problems with the deleteEarly system which uses an untracked
parameter. We now force the PSet for a module to be injected into
the Registry.