Use dynamic_cast instead of reinterpret_cast in HeavyFlavorAnalysis #17173
Conversation
The original code assumed calling reinterpret_cast on a pointer would return 0 if the pointer was of the wrong type. That is not the case. The code was changed to use dynamic_cast instead which does have that behavior.
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_9_0_X. It involves the following packages: HeavyFlavorAnalysis/SpecificDecay @cmsbuild, @monttj, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
The original code assumed calling reinterpret_cast on a pointer
would return 0 if the pointer was of the wrong type. That is not
the case. The code was changed to use dynamic_cast instead which
does have that behavior.
This problem was found by gcc 6.3 (it was a warning).