Use static_cast to call explicitly conversion operator on TString #17230
Conversation
TString in ROOT support std::string_view which was added into C++17 standard and CMSSW since GCC 6 is compiled with C++17. GCC 7 will provide a ful C++17 language support and most of C++ standard library. TString defines two conversion operators, one for const char * and one for std::string_view. The std::string can be constructor by both of them thus causing compiler to error on it. Use static_cast to explicitly select conversion operator which would be compatible with previous C++ standards. Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
|
A new Pull Request was created by @davidlt for CMSSW_9_0_X. It involves the following packages: Fireworks/Core @cmsbuild, @alja, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 |
cmsbuild
added
fully-signed
visualization-approved
and removed
pending-signatures
visualization-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
|
Comparison not run due to Fireworks only changes in PR (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-approved
and removed
comparison-pending
tests-started
labels
|
+1 |
TString in ROOT support std::string_view which was added into C++17
standard and CMSSW since GCC 6 is compiled with C++17. GCC 7 will
provide a ful C++17 language support and most of C++ standard library.
TString defines two conversion operators, one for const char * and one
for std::string_view. The std::string can be constructor by both of them
thus causing compiler to error on it.
Use static_cast to explicitly select conversion operator which would be
compatible with previous C++ standards.
Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch