first DQM based HLT MET monitoring code #17231
Conversation
|
A new Pull Request was created by @mtosi (mia tosi) for CMSSW_9_0_X. It involves the following packages: DQMOffline/Trigger @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
| #include "CommonTools/TriggerUtils/interface/GenericTriggerEventFlag.h" | ||
|
|
||
|
|
||
| double PI = 3.2; |
There was a problem hiding this comment.
3.14159265... is no longer in fashion ?
|
for the TH1, I think it is better having it at 3.2 (binning) |
|
Pull request #17231 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again. |
| double PI = 3.2; | ||
| int NPI = 64; | ||
| MEbinning phi_binning_{ | ||
| 64, -3.2, 3.2 |
There was a problem hiding this comment.
Neither PI nor NPI are actually used, but probably planned to make the above line of magic numbers look better :)
There was a problem hiding this comment.
@mtosi -please remove these unused variables. Thanks
There was a problem hiding this comment.
the downside to using 3.2 is that your phi distribution won't be flat...
|
Pull request #17231 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again. |
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
|
-1 Tested at: b2a3983 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following worklfows: runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log |
|
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
|
Pull request #17231 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again. |
|
@davidlange6 @fwyzard |
|
please test |
|
The tests are being triggered in jenkins. |
|
yes - though I realize a less confusing name for PI=3.2 is PHI_MAX=3.2 and N_PHI=64 |
|
Pull request #17231 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again. |
|
Comparison job queued. |
first DQM based HLT MET monitoring code
| @@ -0,0 +1,32 @@ | |||
| import FWCore.ParameterSet.Config as cms | |||
|
|
|||
| from DQMOffline.Trigger.metMonitoring_cfi import metMonitoring | |||
There was a problem hiding this comment.
Dear developers,
May I ask where this module is located? I couldn't find it in the expected location:
- DQMOffline/Trigger/python/metMonitoring_cfi.py
There was a problem hiding this comment.
It is auto-generated via fillDescriptions:
https://cmssdt.cern.ch/lxr/source/DQMOffline/Trigger/plugins/METMonitor.cc#0273
There was a problem hiding this comment.
Nice. Thanks @Martin-Grunewald for your reply.
|
this is one of the reason why I added
https://github.com/mtosi/cmssw/blob/a1881cd73727973e558cc5eaa53a545ec3e684bf/DQMOffline/Trigger/python/METMonitor_cfi.py
,
because I often use lxr for browsing the code ...
…On Wed, Feb 15, 2017 at 4:37 PM, Jose Cupertino Ruiz Vargas < ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In DQMOffline/Trigger/python/METMonitor_cfi.py
<#17231>:
> @@ -0,0 +1,32 @@
+import FWCore.ParameterSet.Config as cms
+
+from DQMOffline.Trigger.metMonitoring_cfi import metMonitoring
Nice. Thanks @Martin-Grunewald <https://github.com/Martin-Grunewald> for
your reply.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#17231>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEt58zsJF51F_xPJsl2X4HCVHSDuNCGpks5rcxvMgaJpZM4LpgmD>
.
|
|
On 15 February 2017 at 16:42, mia tosi ***@***.***> wrote:
this is one of the reason why I added
https://github.com/mtosi/cmssw/blob/a1881cd73727973e558cc5eaa53a54
5ec3e684bf/DQMOffline/Trigger/python/METMonitor_cfi.py
,
because I often use lxr for browsing the code ...
Just use github to browse the code.
Adding a cfi file with the same content as the autogenerated one is IMHO a
bad idea, because there is no guarantee that they will stay coherent if the
code is changed.
.A
…--
Strategy is a system of expedients.
Generalfeldmarschall Helmuth Karl Bernhard Graf von Moltke
|
|
Hi @mtosi , all nericTriggerEventFlag: METMonitor:PFMETNoMu120_PFMHTNoMu120_METmonitoring@streamBeginRun 15-Mar-2017 13:09:32 CET Run: 1 Stream: 1 |
|
was workflow 1325 step3 for example |
|
opsi
thanks !
I did not realize it before ....weird
I have to cross check, the message comes from the GenericTriggerEventFlag
and it complains about the missing label in the GT ....
it is probably due to the not optimal configuration of the class
I'll look at it tomorrow
mia
…On Wed, Mar 15, 2017 at 5:32 PM, David Lange ***@***.***> wrote:
was workflow 1325 step3 for example
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#17231 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AEt582GI_uV8V_7RjJ-yacgXurFJPr6fks5rmBKzgaJpZM4LpgmD>
.
|
it would be great if this code could be integrated in 900pre3
so we can start looking at the code on data during the release validation
this is one of the first PRs towards the setup of the HLT prompt monitoring
@fwyzard @gennai @Martin-Grunewald @ndaci @dmitrijus @vanbesien @silviodonato