Reading TPG parameters from file #17249
Conversation
|
A new Pull Request was created by @depasse for CMSSW_9_0_X. It involves the following packages: CondTools/Ecal @ggovi, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
+1 |
|
The tests are being triggered in jenkins. |
cmsbuild
added
db-approved
fully-signed
and removed
db-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
|
Comparison job queued. |
| #ifndef ECAL_TPGFINEGRAINTOWER_H | ||
| #define ECAL_TPGFINEGRAINTOWER_H | ||
|
|
||
| #include <vector> |
There was a problem hiding this comment.
@depasse - it looks like only a few of these includes are needed in this header. Please remove the unneeded ones. Thanks
There was a problem hiding this comment.
OK. Done (for both .h files) and resubmitted
cmsbuild
added
comparison-pending
db-pending
pending-signatures
tests-pending
and removed
tests-approved
labels
|
Pull request #17249 was updated. @ggovi, @cmsbuild, @davidlange6 can you please check and sign again. |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
+1 |
cmsbuild
added
db-approved
fully-signed
and removed
db-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
|
+1 |
Reading TPG parameters from TPG_beamv6_trans_xxx_spikekill.txt file