Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TIB Rail Bottom Overlap Bugfix #17261

Merged
merged 1 commit into from Jan 30, 2017

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Jan 24, 2017

  • Remove overlap by making the rail 1.1 mm thinner and moving it by ~ 1 mm

screenshot 2017-01-24 16 32 03

screen shot 2017-01-24 at 17 41 27

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ianna (Ianna Osborne) for CMSSW_9_0_X.

It involves the following packages:

Geometry/CMSCommonData
Geometry/TrackerCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @venturia, @VinInn, @ghugo83 this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@ianna
Copy link
Contributor Author

ianna commented Jan 24, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 24, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17412/console Started: 2017/01/24 17:44

@ianna
Copy link
Contributor Author

ianna commented Jan 24, 2017

@civanch and @veszpv - this was the last of overlaps reported by Vladimir last year. I did not adjust material density for the rail though. Please, check if it is needed.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@ianna
Copy link
Contributor Author

ianna commented Jan 24, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

Pull request #17261 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please check and sign again.

@ianna
Copy link
Contributor Author

ianna commented Jan 30, 2017

please test

@ianna
Copy link
Contributor Author

ianna commented Jan 30, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 30, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17504/console Started: 2017/01/30 19:16

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6 davidlange6 merged commit f8fbded into cms-sw:CMSSW_9_0_X Jan 30, 2017
@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants