bsunanda:Run2-hcx101 Make geometry change to accommodate Plan 1 operation of HCAL #17330

bsunanda · 2017-01-30T22:49:09Z

No description provided.

cmsbuild · 2017-01-30T22:49:26Z

A new Pull Request was created by @bsunanda for CMSSW_9_0_X.

It involves the following packages:

Configuration/Geometry
Geometry/CMSCommonData
Geometry/CaloTopology
Geometry/HcalCommonData
Geometry/HcalTowerAlgo
RecoLocalCalo/CaloTowersCreator
SimCalorimetry/HcalSimAlgos
SimCalorimetry/HcalSimProducers
SimGeneral/CaloAnalysis
Validation/HcalHits

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @dmitrijus, @cmsbuild, @slava77, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald, @mariadalfonso this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

bsunanda · 2017-01-30T22:49:38Z

@cmsbuild Please test

cmsbuild · 2017-01-30T22:49:43Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17516/console Started: 2017/01/30 23:51

cmsbuild · 2017-01-31T01:57:06Z

+1
Tested at: b2b4c41
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17330/17516/summary.html

cmsbuild · 2017-01-31T01:57:09Z

Comparison job queued.

cmsbuild · 2017-01-31T05:56:27Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17330/17516/summary.html

ianna

@bsunanda - updated 2017 base scenario is in CMSSW_9_0_X branch. It should be available in the next IB.

ianna · 2017-01-31T06:43:42Z

Geometry/CMSCommonData/python/cmsExtendedGeometry2017aXML_cfi.py

+
+## 2015 + new phase 1 pixel detector
+
+XMLIdealGeometryESSource = cms.ESSource("XMLIdealGeometryESSource",


@bsunanda - is it yet another HCal scenario? Please, make sure it is synchronised to current 2017 and 2018 ones (e.g. GEM slice + overlap fixes)

This is yet another scenario for HCAL so called Plan-1 where only one RBX of HE is upgraded. The current 2017 scenario is so called Plan-0 where only HF is upgraded and HE is not. The current 2018 scenario is Plan-36 when all 36 RBX's of HE are upgraded.

Could you, please, make sure that this new scenario differs from the default 2017 only in HCal? Thanks.

Yes it does that. I started with 2017 scenario and changed the HCAL part only

It does not have changes which are in pre3:
http://cmslxr.fnal.gov/source/Geometry/CMSCommonData/python/cmsExtendedGeometry2017XML_cfi.py#0237
http://cmslxr.fnal.gov/source/Geometry/CMSCommonData/python/cmsExtendedGeometry2017XML_cfi.py#0237
http://cmslxr.fnal.gov/source/Geometry/CMSCommonData/python/cmsExtendedGeometry2017XML_cfi.py#0272
and some others

please, check it against recent IB

slava77 · 2017-02-02T05:31:42Z

RecoLocalCalo/CaloTowersCreator/src/CaloTowersCreationAlgo.cc

@@ -265,7 +265,7 @@ void CaloTowersCreationAlgo::setGeometry(const CaloTowerTopology* cttopo, const
    std::vector<int> tower28depths;
    int ndepths, startdepth;
    theHcalTopology->getDepthSegmentation(theHcalTopology->lastHERing()-1,tower28depths);
-    theHcalTopology->depthBinInformation(HcalEndcap,theHcalTopology->lastHERing()-1,ndepths,startdepth);
+    theHcalTopology->depthBinInformation(HcalEndcap,theHcalTopology->lastHERing()-1,1,1,ndepths,startdepth);


where is the "plan1" wedge?
.. in case 1,1 is the plan-1 wedge and this happens to be a full phase-1 depth configuration (not hits merged to look like phase-0)

I did a partial work - just make the code compile. It needs further work. Should I take care of this. I thought it is better the Plan-1 version is to be integrated and then we clean up CaloTower, Validation and DQM code needed for this.

it's fine for a work in progress.

Still, where is the "plan1" wedge in units of iphi and zside?

It is z= +1 and phi = 63..66. I am looking into possible changes in the CaloTowerCreationAlgo - we have to introduce zside, phi dependence there

bsunanda · 2017-02-02T16:50:47Z

@slava77 @ianna @civanch Could you kindly approve this so that we can move forward

cmsbuild · 2017-02-02T16:51:07Z

Pull request #17330 was updated. @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @dmitrijus, @kpedro88, @slava77, @vanbesien, @davidlange6 can you please check and sign again.

bsunanda · 2017-02-02T16:53:00Z

@kpedro88 @dmitrijus Please take a look and approve this

bsunanda · 2017-02-02T16:53:33Z

The next set of changes can follow after this

kpedro88 · 2017-02-02T16:57:18Z

+1

davidlange6 · 2017-02-03T12:38:15Z

Hi @bsunanda, your plan doesn’t seem consistent with those describing needs elsewhere.. Tuesday is in any case hopefully soon enough to define a plan in hopes of meeting the needs of CMS...

…

On Feb 3, 2017, at 1:34 PM, bsunanda ***@***.***> wrote: We hope 2018 scenario will be a reality for HCAL in 2018. SO we should certainly keep it. We do need Plan-0 and Plan-1 active for 2017. But please do not make Plan-1 geometry in DB right now. This PR is the very first step. We are working on Plan-1 code actively — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

abdoulline · 2017-02-03T12:49:22Z

Hi David, just would like to emphasize (to avoid possible misunderstanding): Plan-0 and Plan-1 would need to co-exist for some time, as there is no decision which of the two will be chosen for 2017 and, more importantly, there is a probability that even after installation of Plan-1 hardware and all ongoing intensive work to prepare software/condition for it, still Plan-1 can be eventually removed (at the beginning of March the latest), so that "fall-back" Plan-0 would be _the_ 2017 option.

…

On Fri, 3 Feb 2017, David Lange wrote: Hi @bsunanda, your plan doesn’t seem consistent with those describing needs elsewhere.. Tuesday is in any case hopefully soon enough to define a plan in hopes of meeting the needs of CMS... > On Feb 3, 2017, at 1:34 PM, bsunanda ***@***.***> wrote: > > We hope 2018 scenario will be a reality for HCAL in 2018. SO we should certainly keep it. We do need Plan-0 and Plan-1 active for 2017. But please do not make Plan-1 geometry in DB right now. This PR is the very first step. We are working on Plan-1 code actively > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub, or mute the thread. > — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.[AEx02nDXxJ8Dv6bHY3Xv5XEOF6XQX6W4ks5rYx-4gaJpZM4LyBRG.gif]

kpedro88 · 2017-02-03T12:50:50Z

Yes, unfortunately it seems like we'll have to support separate plan0 and plan1 scenarios officially for a while. Once this PR and #17313 are merged, we can try to start putting together the plan1 scenario. JetMET is asking for it on a more or less hourly basis.

davidlange6 · 2017-02-03T12:54:00Z

Yes, I agree. as I said "a plan0/plan1 decision is not going to be made very soon”…so we need to take the time to support both in a stable manner. (and plan36 with a lower priority)

…

On Feb 3, 2017, at 1:49 PM, Salavat Abdullin ***@***.***> wrote: Hi David, just would like to emphasize (to avoid possible misunderstanding): Plan-0 and Plan-1 would need to co-exist for some time, as there is no decision which of the two will be chosen for 2017 and, more importantly, there is a probability that even after installation of Plan-1 hardware and all ongoing intensive work to prepare software/condition for it, still Plan-1 can be eventually removed (at the beginning of March the latest), so that "fall-back" Plan-0 would be _the_ 2017 option. On Fri, 3 Feb 2017, David Lange wrote: > Hi @bsunanda, your plan doesn’t seem consistent with those describing needs elsewhere.. Tuesday is in any case > hopefully soon enough to define a plan in hopes of meeting the needs of CMS... > > > On Feb 3, 2017, at 1:34 PM, bsunanda ***@***.***> wrote: > > > > We hope 2018 scenario will be a reality for HCAL in 2018. SO we should certainly keep it. We do need Plan-0 and > Plan-1 active for 2017. But please do not make Plan-1 geometry in DB right now. This PR is the very first step. We are > working on Plan-1 code actively > > > > — > > You are receiving this because you were mentioned. > > Reply to this email directly, view it on GitHub, or mute the thread. > > > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub, or mute the > thread.[AEx02nDXxJ8Dv6bHY3Xv5XEOF6XQX6W4ks5rYx-4gaJpZM4LyBRG.gif] > > > — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

ianna · 2017-02-03T13:05:21Z

@bsunanda - there is no place in DB for Plan1 now. If we have to support both Plan0 and Plan1 we'll need a new GT queue unless HCal re-writes the code for conditions and reco geometry to have labels.

@franzoni - FYI

kpedro88 · 2017-02-03T14:48:19Z

If we're going to change the name of 2017dev to 2017Plan1, it would be nice to add it to GeometryConf.py also

bsunanda · 2017-02-03T15:32:35Z

I shall do that in the next PR - let this be integrated first

davidlange6 · 2017-02-03T15:35:00Z

its a git mv then git push no? it should be straightforward to have it here and avoid the history messiness

slava77 · 2017-02-03T17:23:09Z

+1

for #17330 7c55342

reco part of the changes is rather technical, to update to the new interface of HcalTopology::depthBinInformation
jenkins tests pass and comparisons show no differences

bsunanda · 2017-02-04T23:50:06Z

@dmitrijus Please approve this at the earliest
@davidlange6 Kindly merge this at the earliest so that I can add next set of changes to this

bsunanda · 2017-02-06T14:42:07Z

@davidlange6 Could you merge this at the earliest - it stops me to go to the next step

abdoulline · 2017-02-06T14:59:07Z

@davidlange6 David, this is a base/basis, right now we cannot move with Plan 1 in several domains...

…

On Mon, 6 Feb 2017, bsunanda wrote: @davidlange6 Could you merge this at the earliest - it stops me to go to the next step — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.[AEx02k6UWLsgIskUsP_YawJEr9fd8Uogks5rZzFBgaJpZM4LyBRG.gif]

davidlange6 · 2017-02-06T15:08:34Z

so far my request is even unanswered...we've a mix of 2017dev 2017a 17b blah blah. Lets fix a naming convention and get it in this PR - I think people were happy with 2017Plan1

bsunanda · 2017-02-06T15:15:35Z

I shall rename the scenario as 2017Plan1 in the next PR

davidlange6 · 2017-02-06T15:41:24Z

can you at least comment on what the issue is that prevents it here? it would be nice to have a PR with all the naming conventions established from the start

…

On Feb 6, 2017, at 4:15 PM, bsunanda ***@***.***> wrote: I shall rename the scenario as 2017Plan1 in the next PR — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

bsunanda · 2017-02-06T19:50:31Z

@davidlange6 Please let it go - we shall miss the timeline for participation in global run otherwise

dmitrijus · 2017-02-07T12:51:02Z

+1

cmsbuild · 2017-02-07T12:51:21Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

davidlange6 · 2017-02-07T16:58:29Z

+1

Make geometry change to accommodate Plan 1 operation of HCAL

b2b4c41

cmsbuild added this to the Next CMSSW_9_0_X milestone Jan 30, 2017

cmsbuild added comparison-pending dqm-pending geometry-pending orp-pending pending-signatures reconstruction-pending simulation-pending tests-pending labels Jan 30, 2017

cmsbuild added tests-started and removed tests-pending labels Jan 30, 2017

cmsbuild added tests-approved and removed tests-started labels Jan 31, 2017

cmsbuild added comparison-available and removed comparison-pending labels Jan 31, 2017

ianna suggested changes Jan 31, 2017

View reviewed changes

slava77 reviewed Feb 2, 2017

View reviewed changes

cmsbuild added the upgrade-pending label Feb 2, 2017

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Feb 3, 2017

kpedro88 mentioned this pull request Feb 6, 2017

Initial implementation of Plan 1 rechit combination #17313

Merged

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Feb 7, 2017

cmsbuild added orp-approved and removed orp-pending labels Feb 7, 2017

cmsbuild merged commit 6e950fa into cms-sw:CMSSW_9_0_X Feb 7, 2017

kpedro88 mentioned this pull request Feb 7, 2017

Simplify TestNumbering handling #17369

Merged


		## 2015 + new phase 1 pixel detector

		XMLIdealGeometryESSource = cms.ESSource("XMLIdealGeometryESSource",

bsunanda:Run2-hcx101 Make geometry change to accommodate Plan 1 operation of HCAL #17330

bsunanda:Run2-hcx101 Make geometry change to accommodate Plan 1 operation of HCAL #17330

Conversation

bsunanda commented Jan 30, 2017

cmsbuild commented Jan 30, 2017

bsunanda commented Jan 30, 2017

cmsbuild commented Jan 30, 2017 • edited

cmsbuild commented Jan 31, 2017

cmsbuild commented Jan 31, 2017

cmsbuild commented Jan 31, 2017

ianna left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bsunanda commented Feb 2, 2017

cmsbuild commented Feb 2, 2017

bsunanda commented Feb 2, 2017

bsunanda commented Feb 2, 2017

kpedro88 commented Feb 2, 2017

davidlange6 commented Feb 3, 2017 via email

abdoulline commented Feb 3, 2017 via email

kpedro88 commented Feb 3, 2017

davidlange6 commented Feb 3, 2017 via email

ianna commented Feb 3, 2017

kpedro88 commented Feb 3, 2017

bsunanda commented Feb 3, 2017

davidlange6 commented Feb 3, 2017

slava77 commented Feb 3, 2017

bsunanda commented Feb 4, 2017

bsunanda commented Feb 6, 2017

abdoulline commented Feb 6, 2017 via email • edited

davidlange6 commented Feb 6, 2017

bsunanda commented Feb 6, 2017

davidlange6 commented Feb 6, 2017 via email

bsunanda commented Feb 6, 2017

dmitrijus commented Feb 7, 2017

cmsbuild commented Feb 7, 2017

davidlange6 commented Feb 7, 2017

cmsbuild commented Jan 30, 2017 •

edited

abdoulline commented Feb 6, 2017 via email •

edited