DataFormats/Common : Changes needed to compile with macOS clang and libc++ #17348

gartung · 2017-01-31T19:44:17Z

No description provided.

cmsbuild · 2017-01-31T19:44:34Z

A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_9_0_X.

It involves the following packages:

DataFormats/Common

@cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @wddgit, @wmtan this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

Dr15Jones · 2017-01-31T21:04:38Z

DataFormats/Common/interface/RangeMap.h

@@ -78,6 +77,9 @@ namespace edm {
    /// to use only comparators provided with CMSSW release.
    template<typename CMP> 
    range get(ID id, CMP comparator) const {
+#ifndef _LIBCPP_VERSION


Can we try removing this all together to see if it was needed at all?

I think it gets used in the main cpp file.

please try rebuilding without this using.

gartung · 2017-02-07T16:54:49Z

Probably needs to be merged at the same time as
#17351

cmsbuild · 2017-02-07T17:14:24Z

Pull request #17348 was updated. @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please check and sign again.

Dr15Jones · 2017-02-07T18:37:23Z

please test

cmsbuild · 2017-02-07T18:37:41Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17674/console Started: 2017/02/07 19:40

cmsbuild · 2017-02-07T18:44:56Z

-1

Tested at: 498136e

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17348/17674/summary.html

I found follow errors while testing this PR

Failed tests: Build ClangBuild

Build:

I found an error when building:

>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-02-06-2300/src/DataFormats/Common/test/testOneToManyAssociation.cc 
>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-02-06-2300/src/DataFormats/Common/test/testAssociationVector.cc 
In file included from /cvmfs/cms-ib.cern.ch/nweek-02458/slc6_amd64_gcc530/external/gcc/5.3.0/include/c++/5.3.0/cassert:43:0,
                 from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-02-06-2300/src/DataFormats/Common/test/testBoostRange.cpp:9:
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-02-06-2300/src/DataFormats/Common/test/testBoostRange.cpp: In function 'void test_sort(R)':
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-02-06-2300/src/DataFormats/Common/test/testBoostRange.cpp:99:13: error: 'is_sorted' is not a member of '__gnu_cxx'
     assert(!__gnu_cxx::is_sorted(r.begin(), r.end(), DummySorter()));
             ^
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-02-06-2300/src/DataFormats/Common/test/testBoostRange.cpp:99:13: note: suggested alternative:
In file included from /cvmfs/cms-ib.cern.ch/nweek-02458/slc6_amd64_gcc530/external/gcc/5.3.0/include/c++/5.3.0/algorithm:62:0,
                 from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-02-06-2300/src/DataFormats/Common/interface/OrphanHandleBase.h:25,

Clang:

I found a compilation error while trying to compile with clang:
I used this command:
scram b vclean && scram build -k -j 16 USER_CXXFLAGS='-fsyntax-only' COMPILER='llvm compile'

Selected class -> edm::Wrapper for ROOT: edm::Wrapper> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-02-06-2300/src/DataFormats/Common/test/testRangeMap.cc 
>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-02-06-2300/src/DataFormats/Common/test/testSortedCollection.cc 
>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-02-06-2300/src/DataFormats/Common/test/testIDVectorMap.cc 
>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-02-06-2300/src/DataFormats/Common/test/ref_t.cppunit.cc 
>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-02-06-2300/src/DataFormats/Common/test/DetSetRefVector_t.cppunit.cc 
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-02-06-2300/src/DataFormats/Common/test/testBoostRange.cpp:99:13: error: no member named 'is_sorted' in namespace '__gnu_cxx'; did you mean 'std::is_sorted'?
    assert(!__gnu_cxx::is_sorted(r.begin(), r.end(), DummySorter()));
            ^~~~~~~~~~~~~~~~~~~~
            std::is_sorted
/usr/include/assert.h:89:5: note: expanded from macro 'assert'
  ((expr)                                                               \

cmsbuild · 2017-02-07T18:44:58Z

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

Dr15Jones · 2017-02-07T19:30:51Z

Try replacing __gnu_cxx::is_sorted with std::is_sorted.
http://en.cppreference.com/w/cpp/algorithm/is_sorted

cmsbuild · 2017-02-07T19:43:48Z

Pull request #17348 was updated. @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please check and sign again.

Dr15Jones · 2017-02-07T20:11:56Z

please test

cmsbuild · 2017-02-07T20:12:12Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17676/console Started: 2017/02/07 21:12

cmsbuild · 2017-02-07T21:18:42Z

+1
Tested at: 32d9b54
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17348/17676/summary.html

cmsbuild · 2017-02-07T21:18:45Z

Comparison job queued.

Dr15Jones · 2017-02-07T21:20:26Z

+1

cmsbuild · 2017-02-07T21:20:59Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

cmsbuild · 2017-02-07T23:43:47Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17348/17676/summary.html

davidlange6 · 2017-02-08T09:34:12Z

+1
(better to avoid unneeded whitespace changes in header files in the future...)

gartung · 2017-02-08T15:14:51Z

@davidlange6 whitespace was a remnant of a merge. Pardon my spaces...

Changes needed to compile with macOS clang and libc++

1e9e095

cmsbuild added this to the Next CMSSW_9_0_X milestone Jan 31, 2017

cmsbuild added comparison-pending core-pending orp-pending pending-signatures tests-pending labels Jan 31, 2017

gartung changed the title ~~Changes needed to compile with macOS clang and libc++~~ DataFormats/Common : Changes needed to compile with macOS clang and libc++ Jan 31, 2017

Dr15Jones reviewed Jan 31, 2017

View reviewed changes

remove using statment completely

498136e

cmsbuild added tests-started and removed tests-pending labels Feb 7, 2017

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Feb 7, 2017

remove __gnu namespace

32d9b54

cmsbuild added comparison-pending tests-pending and removed comparison-notrun tests-rejected labels Feb 7, 2017

cmsbuild added tests-started and removed tests-pending labels Feb 7, 2017

cmsbuild added tests-approved and removed tests-started labels Feb 7, 2017

cmsbuild added core-approved fully-signed and removed core-pending pending-signatures labels Feb 7, 2017

cmsbuild added comparison-available and removed comparison-pending labels Feb 7, 2017

cmsbuild added orp-approved and removed orp-pending labels Feb 8, 2017

cmsbuild merged commit f3c06e8 into cms-sw:CMSSW_9_0_X Feb 8, 2017

gartung deleted the DataFormats-Common-macos-clang-fixes branch March 13, 2017 18:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DataFormats/Common : Changes needed to compile with macOS clang and libc++ #17348

DataFormats/Common : Changes needed to compile with macOS clang and libc++ #17348

gartung commented Jan 31, 2017

cmsbuild commented Jan 31, 2017

Dr15Jones Jan 31, 2017

gartung Jan 31, 2017

Dr15Jones Feb 7, 2017

gartung Feb 7, 2017

gartung commented Feb 7, 2017

cmsbuild commented Feb 7, 2017

Dr15Jones commented Feb 7, 2017

cmsbuild commented Feb 7, 2017 •

edited

cmsbuild commented Feb 7, 2017

cmsbuild commented Feb 7, 2017

Dr15Jones commented Feb 7, 2017

cmsbuild commented Feb 7, 2017

Dr15Jones commented Feb 7, 2017

cmsbuild commented Feb 7, 2017 •

edited

cmsbuild commented Feb 7, 2017

cmsbuild commented Feb 7, 2017

Dr15Jones commented Feb 7, 2017

cmsbuild commented Feb 7, 2017

cmsbuild commented Feb 7, 2017

davidlange6 commented Feb 8, 2017

gartung commented Feb 8, 2017

DataFormats/Common : Changes needed to compile with macOS clang and libc++ #17348

DataFormats/Common : Changes needed to compile with macOS clang and libc++ #17348

Conversation

gartung commented Jan 31, 2017

cmsbuild commented Jan 31, 2017

Dr15Jones Jan 31, 2017

Choose a reason for hiding this comment

gartung Jan 31, 2017

Choose a reason for hiding this comment

Dr15Jones Feb 7, 2017

Choose a reason for hiding this comment

gartung Feb 7, 2017

Choose a reason for hiding this comment

gartung commented Feb 7, 2017

cmsbuild commented Feb 7, 2017

Dr15Jones commented Feb 7, 2017

cmsbuild commented Feb 7, 2017 • edited

cmsbuild commented Feb 7, 2017

cmsbuild commented Feb 7, 2017

Dr15Jones commented Feb 7, 2017

cmsbuild commented Feb 7, 2017

Dr15Jones commented Feb 7, 2017

cmsbuild commented Feb 7, 2017 • edited

cmsbuild commented Feb 7, 2017

cmsbuild commented Feb 7, 2017

Dr15Jones commented Feb 7, 2017

cmsbuild commented Feb 7, 2017

cmsbuild commented Feb 7, 2017

davidlange6 commented Feb 8, 2017

gartung commented Feb 8, 2017

cmsbuild commented Feb 7, 2017 •

edited

cmsbuild commented Feb 7, 2017 •

edited