Global modules need per thread provenance #1735
Conversation
The global module had a bug where all streams were using the same data structures to record their provenance. Now we set aside space for each Stream to have its own provenance information.
Now that global modules set up per Stream data structures to record provenance, TriggerResultsInserter, which is a global module, needs to have its doPreallocate method called. This avoids a segmentation fault.
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_0_X. Global modules need per thread provenance It involves the following packages: FWCore/Framework @cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it? |
|
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it? |
…venance Multithreaded framework -- Global modules need per thread provenance
The global module had a bug where all streams were using the same data structures to record their provenance. Now we set aside space for each Stream to have its own provenance information.
As part of this change, the TriggerResultsInserter, which is a global module which is handled in a special way by the framework, needs its doPreallocate method called.