Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fireworks/Core : Changes needed to compile with macOS clang and libc++ #17354

Merged
merged 1 commit into from Feb 1, 2017
Merged

Fireworks/Core : Changes needed to compile with macOS clang and libc++ #17354

merged 1 commit into from Feb 1, 2017

Conversation

gartung
Copy link
Member

@gartung gartung commented Jan 31, 2017

No description provided.

@cmsbuild cmsbuild added this to the Next CMSSW_9_0_X milestone Jan 31, 2017
@gartung gartung changed the title Changes needed to compile with macOS clang and libc++ Fireworks/Core : Changes needed to compile with macOS clang and libc++ Jan 31, 2017
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_9_0_X.

It involves the following packages:

Fireworks/Core

@cmsbuild, @alja, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@alja this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@Dr15Jones
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 31, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17544/console Started: 2017/01/31 22:07

@Dr15Jones
Copy link
Contributor

@smuzaffar are you OK with these BuildFile.xml changes?

@alja
Copy link
Contributor

alja commented Jan 31, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@smuzaffar
Copy link
Contributor

@Dr15Jones , for now, these changes are fine but we should add a rootgx11 toolfile instead of directly linking against the library here.

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17354/17544/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • 10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018Design_GenSimFull+DigiFull_2018Design+RecoFull_2018Design+HARVESTFull_2018Design
  • 20034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D7_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D7+RecoFullGlobal_2023D7+HARVESTFullGlobal_2023D7
  • 21234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D4_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D4+RecoFullGlobal_2023D4+HARVESTFullGlobal_2023D4
  • 23234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D8_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D8+RecoFullGlobal_2023D8+HARVESTFullGlobal_2023D8

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit be684dc into cms-sw:CMSSW_9_0_X Feb 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants