Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable Pixel Cluster Shape in LowPtSeedComparitor #17393

Merged

Conversation

ebrondol
Copy link
Contributor

@ebrondol ebrondol commented Feb 2, 2017

After a private chat with @makortel, we decided to set the pixel cluster shape filter in the 'LowPtClusterShapeSeedComparitor' configurable. The 'LowPtClusterShapeSeedComparitor' is used for all pixel use cases and the cluster shape filtering name was set hard-coded to 'ClusterShapeHitFilter'.
This change increases the flexibility of the code and the relationship between the two is also showing up in edmConfigDump, while it was not clear before.
No changes are expected in any phases.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2017

A new Pull Request was created by @ebrondol for CMSSW_9_0_X.

It involves the following packages:

RecoPixelVertexing/PixelLowPtUtilities

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @dgulhan this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@slava77
Copy link
Contributor

slava77 commented Feb 2, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17597/console Started: 2017/02/02 20:17

@makortel
Copy link
Contributor

makortel commented Feb 2, 2017

Thanks @ebrondol. But I'm afraid this is not enough because LowPtClusterShapeSeedComparitor appears to be used in HLT. But we'll see if the tests succeed or fail.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2017

-1

Tested at: 06ac88e

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17393/17597/summary.html

I found follow errors while testing this PR

Failed tests: RelVals AddOn

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
136.731 step2

runTheMatrix-results/136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2/step2_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2.log

1306.0 step2
runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step2_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log

1330.0 step2
runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step2_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log

25202.0 step2
runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log

10021.0 step2
runTheMatrix-results/10021.0_TenMuE_0_200+TenMuE_0_200_pythia8_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step2_TenMuE_0_200+TenMuE_0_200_pythia8_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

10024.0 step2
runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step2_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

  • AddOn:

I found errors in the following addon tests:

cmsRun /cvmfs/cms-ib.cern.ch/nweek-02457/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_0_X_2017-02-01-2300/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Thu Feb 2 21:04:08 2017-date Thu Feb 2 21:01:57 2017 s - exit: 18688
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PRef_DATA.root --fileout file:RelVal_Raw_PRef_DATA_HLT_RECO.root : FAILED - time: date Thu Feb 2 21:04:08 2017-date Thu Feb 2 21:01:57 2017 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02457/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_0_X_2017-02-01-2300/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Thu Feb 2 21:05:04 2017-date Thu Feb 2 21:01:59 2017 s - exit: 18688
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --data --scenario=HeavyIons -n 10 --conditions auto:run2_data_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016,Run2_HI --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_HIon_DATA.root --fileout file:RelVal_Raw_HIon_DATA_HLT_RECO.root : FAILED - time: date Thu Feb 2 21:05:04 2017-date Thu Feb 2 21:01:59 2017 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02457/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_0_X_2017-02-01-2300/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Thu Feb 2 21:09:56 2017-date Thu Feb 2 21:02:01 2017 s - exit: 18688
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_GRun_MC.root --fileout file:RelVal_Raw_GRun_MC_HLT_RECO.root : FAILED - time: date Thu Feb 2 21:09:56 2017-date Thu Feb 2 21:02:01 2017 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02457/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_0_X_2017-02-01-2300/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Thu Feb 2 21:08:23 2017-date Thu Feb 2 21:02:04 2017 s - exit: 18688
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PRef_MC.root --fileout file:RelVal_Raw_PRef_MC_HLT_RECO.root : FAILED - time: date Thu Feb 2 21:08:23 2017-date Thu Feb 2 21:02:04 2017 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02457/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_0_X_2017-02-01-2300/src/HLTrigger/Configuration/test/OnLine_HLT_PIon.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Thu Feb 2 21:06:44 2017-date Thu Feb 2 21:02:42 2017 s - exit: 18688
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PIon_DATA.root --fileout file:RelVal_Raw_PIon_DATA_HLT_RECO.root : FAILED - time: date Thu Feb 2 21:06:44 2017-date Thu Feb 2 21:02:42 2017 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02457/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_0_X_2017-02-01-2300/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Thu Feb 2 21:12:16 2017-date Thu Feb 2 21:05:08 2017 s - exit: 18688
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --mc --scenario=HeavyIons -n 10 --conditions auto:run2_mc_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016,Run2_HI --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_HIon_MC.root --fileout file:RelVal_Raw_HIon_MC_HLT_RECO.root : FAILED - time: date Thu Feb 2 21:12:16 2017-date Thu Feb 2 21:05:08 2017 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02457/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_0_X_2017-02-01-2300/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Thu Feb 2 21:11:49 2017-date Thu Feb 2 21:07:23 2017 s - exit: 18688
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_25ns --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_GRun_DATA.root --fileout file:RelVal_Raw_GRun_DATA_HLT_RECO.root : FAILED - time: date Thu Feb 2 21:11:49 2017-date Thu Feb 2 21:07:23 2017 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02457/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_0_X_2017-02-01-2300/src/HLTrigger/Configuration/test/OnLine_HLT_PIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Thu Feb 2 21:15:09 2017-date Thu Feb 2 21:10:06 2017 s - exit: 18688
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PIon_MC.root --fileout file:RelVal_Raw_PIon_MC_HLT_RECO.root : FAILED - time: date Thu Feb 2 21:15:09 2017-date Thu Feb 2 21:10:06 2017 s - exit: 18688

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2017

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@slava77
Copy link
Contributor

slava77 commented Feb 3, 2017 via email

@makortel
Copy link
Contributor

makortel commented Feb 3, 2017

If it's not feasible to get this in through fillDescriptions,
make a customise for HLT.

IMHO not feasible. It would require transforming all SeedComparitors to ED/ESProducers, and I'd much rather revamp the whole SeedComparitor infrastructure instead (it's messy and confusing to understand).

@ebrondol
Copy link
Contributor Author

ebrondol commented Feb 4, 2017

Ok, I did not know that. Was I suppose to close this PR?

@slava77
Copy link
Contributor

slava77 commented Feb 4, 2017 via email

@ebrondol
Copy link
Contributor Author

ebrondol commented Feb 6, 2017

@slava77 working on that.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2017

Pull request #17393 was updated. @perrotta, @cmsbuild, @silviodonato, @cvuosalo, @fwyzard, @Martin-Grunewald, @slava77, @davidlange6 can you please check and sign again.

@slava77
Copy link
Contributor

slava77 commented Feb 6, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17643/console Started: 2017/02/06 18:23

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2017

@slava77
Copy link
Contributor

slava77 commented Feb 6, 2017

+1

for #17393 9d444d7

  • changes are in line with the PR description: change hardcoded value to a configurable parameter
  • jenkins tests pass and comparisons with baseline show no differences

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 567baec into cms-sw:CMSSW_9_0_X Feb 7, 2017
for producer in producers_by_type(process,"PixelTripletHLTEDProducer"):
if hasattr(producer,'SeedComparitorPSet'):
if (producer.SeedComparitorPSet.ComponentName.value() == 'LowPtClusterShapeSeedComparitor'):
producer.SeedComparitorPSet.clusterShapeHitFilter = cms.string('ClusterShapeHitFilter')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ebrondol , in this way you always overwrite clusterShapeHitFilter in all 'LowPtClusterShapeSeedComparitor' component.
In other word we cannot control the clusterShapeHitFilter value from the HLT configuration, because it will be always overwritten by 'ClusterShapeHitFilter'. Did you want this? Did you forget to add if not hasattr(producer.SeedComparitorPSet,'clusterShapeHitFilter') ? Thanks for the check, Silvio.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, sorry for the delay. Yes, you are completely right. I will address it asap. Thanks for spotting the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants