Simple Service to make a GraphViz graph of the modules runtime dependencies #17417
Conversation
…es runtime dependencies
…uled modue in each path
|
please test |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_9_0_X. It involves the following packages: FWCore/Services @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
Comparison job queued. |
| <use name="gcc-atomic"/> | ||
| <library file="*.cc" name="FWCoreServicesPlugins"> | ||
| <flags EDM_PLUGIN="1"/> | ||
| <flags CXXFLAGS="-Wno-maybe-uninitialized"/> |
There was a problem hiding this comment.
@smuzaffar are you OK with this flag?
There was a problem hiding this comment.
if there is a way f disabling the check only in the boost headers, that works for me as well...
There was a problem hiding this comment.
@fwyzard , no there is no way to disable it only for boost. If you are worrying about getting these warnings in IB logs then we do ignore warnings coming from externals.
There was a problem hiding this comment.
The problem is that we have -Werror=maybe-uninitialized so they become actual build errors.
If you prefer I can use -Wno-error=maybe-uninitialized to turn them back into warnings.
|
Pull request #17417 was updated. @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please check and sign again. |
|
OK, I have updated the service based on the feedback at the core software meeting:
|
|
please test |
|
The tests are being triggered in jenkins. |
| <library file="DependencyGraph.cc" name="FWCoreServicesDependencyGraphPlugin"> | ||
| <flags EDM_PLUGIN="1"/> | ||
| <flags CXXFLAGS="-Wno-maybe-uninitialized"/> | ||
| </library> |
There was a problem hiding this comment.
@Dr15Jones , this looks good to me.
|
+1 |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
|
apologies that I missed the discussion - what warnings are we trying to work around in this PR? |
|
Boost has some "maybe-uninitialized" variables, and since we normally compile with |
|
ok , thanks - hopefully a new version of boost fixes such issues:) |
|
+1 |
|
Comparison job queued. |
Simple Service to make a GraphViz graph of the modules runtime dependencies:
Use GraphViz dot to generate an SVG representation of the dependencies: