Update JetID Functor to new recommendations #17439
Conversation
|
A new Pull Request was created by @gkasieczka for CMSSW_9_0_X. It involves the following packages: PhysicsTools/SelectorUtils @cmsbuild, @monttj, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
On 2/7/17 1:58 AM, gkasieczka wrote:
There are still a few places in DQM where the old RUNIISTARTUP version
is used (see [2]). Who is responsible to update these? Or can I just go
ahead?
If you know what to change, please change.
Thank you.
|
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Pull request #17439 was updated. @cmsbuild, @dmitrijus, @vanbesien, @monttj, @davidlange6 can you please check and sign again. |
|
Also updated the DQM uses of JetID now. |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
+1 |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
cmsbuild
added
analysis-approved
fully-signed
and removed
analysis-pending
pending-signatures
labels
|
+1 |
Current JetID recommendations are available at: [1]
This PR brings the PFJetIDSelectionFunctor up to date with them.
Verified on ~1k jets: all jets for which the JetID changes are in 2.7 < abs(eta) <= 3.0 and the new JetID
agrees with the requirements in the table.
There are still a few places in DQM where the old RUNIISTARTUP version is used (see [2]). Who is responsible to update these? Or can I just go ahead?
[1] https://twiki.cern.ch/twiki/bin/view/CMS/JetID13TeVRun2016
[2] https://github.com/cms-sw/cmssw/search?utf8=%E2%9C%93&q=RUNIISTARTUP