add validation for GsfTracks @HLT #17447

mtosi · 2017-02-07T15:53:48Z

as requested by EGM
I'm adding the validation plots for GSF tracks @HLT
@gpasztor @fcouderc @paramatti @dmitrijus

cmsbuild · 2017-02-07T15:56:11Z

A new Pull Request was created by @mtosi (mia tosi) for CMSSW_9_0_X.

It involves the following packages:

HLTriggerOffline/Common
HLTriggerOffline/Egamma
Validation/RecoTrack

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @wmtford, @dgulhan this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

dmitrijus · 2017-02-07T16:03:33Z

+1

cmsbuild · 2017-02-07T16:03:54Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17670/console Started: 2017/02/07 17:06

cmsbuild · 2017-02-07T16:03:55Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

makortel · 2017-02-07T16:06:56Z

HLTriggerOffline/Egamma/python/HLTmultiTrackValidatorGsfTracks_cff.py

+hltGsfTrackValidator.histoProducerAlgoBlock.TpSelectorForEfficiencyVsVTXR.maxRapidity = cms.double( 3.0)
+hltGsfTrackValidator.histoProducerAlgoBlock.TpSelectorForEfficiencyVsVTXR.minRapidity = cms.double(-3.0)
+hltGsfTrackValidator.histoProducerAlgoBlock.TpSelectorForEfficiencyVsVTXZ.maxRapidity = cms.double( 3.0)
+hltGsfTrackValidator.histoProducerAlgoBlock.TpSelectorForEfficiencyVsVTXZ.minRapidity = cms.double(-3.0)


The eta limits for all the TpSelector*'s are already controlled with eras (i.e. set to +-3 for phase1) in
https://github.com/cms-sw/cmssw/blob/CMSSW_9_0_X/Validation/RecoTrack/python/TrackingParticleSelectionsForEfficiency_cff.py
Please continue using those (if they don't get propagated here for some reason, that should be fixed instead)

The GpSelector* are not, but the MultiTrackValidatorGenPs is probably out-of-date anyway (and not used in standard workflows).

thanks @makortel
but here the eta range does not depend on the era, but on the ECAL acceptance

Ok, fair point. Could you then add a comment explaining that?

Then the above could be also written in a less verbose way

hltGsfTrackValidator = hltMultiTrackValidator.clone( ..., histoProducerAlgoBlock = dict( TpSelectorForEfficiencyVsEta = dict(minRapidity=-3, maxRapidity=3), TpSelectorForEfficiencyVsPhi = dict(minRapidity=-3, maxRapidity=3), ... ) )

(I'd just ignore the GpSelector* as they're not used in practice)

makortel · 2017-02-07T16:09:28Z

HLTriggerOffline/Egamma/python/HLTmultiTrackValidatorGsfTracks_cff.py

+hltGsfTrackValidator.histoProducerAlgoBlock.generalTpSelector.maxRapidity = cms.double( 3.0)
+hltGsfTrackValidator.histoProducerAlgoBlock.generalTpSelector.minRapidity = cms.double(-3.0)
+hltGsfTrackValidator.maxRapidityTP = cms.double( 3.0)
+hltGsfTrackValidator.minRapidityTP = cms.double(-3.0)


These two are also already controlled with eras (set to +-3 for phae1) in
https://github.com/cms-sw/cmssw/blob/CMSSW_9_0_X/Validation/RecoTrack/python/TrackingParticleSelectionForEfficiency_cfi.py

makortel · 2017-02-07T16:10:31Z

HLTriggerOffline/Egamma/python/HLTmultiTrackValidatorGsfTracks_cff.py

+hltGsfTrackValidator.maxRapidityTP = cms.double( 3.0)
+hltGsfTrackValidator.minRapidityTP = cms.double(-3.0)
+hltGsfTrackValidator.maxEta = cms.double( 3.0)
+hltGsfTrackValidator.minEta = cms.double(-3.0)


These two don't do anything, please remove.

(In general, when modifying existing parameter, I'd suggest to avoid the explicit type on right hand side to benefit from typo checking. Without cms.double it should raise an exception here).

makortel · 2017-02-07T16:11:44Z

HLTriggerOffline/Egamma/python/HLTmultiTrackValidator_cff.py

+    hltTPClusterProducer
+    + hltTrackAssociatorByHits
+    + hltTrackValidator
+)    


This file is exactly the same as https://github.com/cms-sw/cmssw/blob/CMSSW_9_0_X/Validation/RecoTrack/python/HLTmultiTrackValidator_cff.py. Why another copy would be needed?

makortel · 2017-02-07T16:12:46Z

HLTriggerOffline/Egamma/python/HLTmultiTrackValidator_cfi.py

+hltMultiTrackValidator.ignoremissingtrackcollection = cms.untracked.bool(True)
+
+hltMultiTrackValidator.UseAssociators = True
+hltMultiTrackValidator.associators = ['hltTrackAssociatorByHits']


This file is functionally the same as https://github.com/cms-sw/cmssw/blob/CMSSW_9_0_X/Validation/RecoTrack/python/HLTmultiTrackValidator_cfi.py. Why another copy would be needed?

makortel · 2017-02-07T16:13:45Z

Validation/RecoTrack/python/associators_cff.py

+    label_tp = cms.InputTag("mix","MergedTrackTruth"),
+    associator = cms.InputTag('hltTrackAssociatorByHits'),
+    ignoremissingtrackcollection = cms.untracked.bool(True)
+)


This is not used, I'd suggest to remove.

makortel · 2017-02-07T16:19:58Z

HLTriggerOffline/Common/python/HLTValidation_cff.py

    )
 from Configuration.Eras.Modifier_phase1Pixel_cff import phase1Pixel

 hltvalidation = cms.Sequence(
    HLTMuonVal
+    +hltMultiTrackValidationGsfTracks


I'd prefer to have all MTV instances in the "prevalidation" Path (i.e. hltassociation sequence) for consistency (and because there is no reason for these to be in EndPath).

makortel · 2017-02-07T16:22:31Z

HLTriggerOffline/Egamma/python/HLTmultiTrackValidatorGsfTracks_cff.py

+    hltTPClusterProducer
+    + hltTrackAssociatorByHits
+#    + cms.ignore(trackingParticlesElectron)    
+    + hltGsfTracksPreValidation


I don't understand why hltGsfTracksPreValidation is inserted in hltMultiTrackValidationGsfTracks sequence here, while they are inserted in hltassociation and hltvalidation sequences in HLTValidation_cff.py, respectively.

Following my comment there, I'd suggest to remove the hltGsfTracksPreValidation sequence altogether, uncomment the trackingParticlesElectron in above, and in HLTValidation_cff.py insert hltMultiTrackValidationGsfTracks in hltassociation.

cmsbuild · 2017-02-07T18:08:43Z

-1

Tested at: 2536943

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17447/17670/summary.html

I found follow errors while testing this PR

Failed tests: RelVals AddOn

RelVals:

When I ran the RelVals I found an error in the following worklfows:
5.1 step1

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log

135.4 step1

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log

AddOn:

I found errors in the following addon tests:

cmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi --conditions auto:run1_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,HLT:@Fake,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - time: date Tue Feb 7 18:38:02 2017-date Tue Feb 7 18:35:04 2017 s - exit: 16640
cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,HLT:@relval25ns,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns --magField 38T_PostLS1 : FAILED - time: date Tue Feb 7 18:38:44 2017-date Tue Feb 7 18:35:19 2017 s - exit: 16640
cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,HLT:@relval2016,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_2016 --magField 38T_PostLS1 : FAILED - time: date Tue Feb 7 18:48:08 2017-date Tue Feb 7 18:35:25 2017 s - exit: 16640

cmsbuild · 2017-02-07T18:08:55Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

cmsbuild · 2017-02-08T09:48:02Z

Pull request #17447 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again.

fcouderc · 2017-02-08T11:20:00Z

adding @rafaellopesdesa

cmsbuild · 2017-02-08T11:34:40Z

Pull request #17447 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again.

makortel · 2017-02-08T12:48:23Z

Thanks Mia! For FastSim, until #17224 is merged, I guess you would need to remove also hltMultiTrackValidationGsfTracks from hltassociation.

mtosi · 2017-02-08T12:54:35Z

I think I tested w/ FastSim workflow w/o any issue
until PR #17224 and Martin's one are merged, we will run HLT step in FastSim

makortel · 2017-02-08T12:58:52Z

@cmsbuild, please test

Ok, let's test it then (earlier there were failures).

cmsbuild · 2017-02-08T12:59:08Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17691/console Started: 2017/02/08 15:25

cmsbuild · 2017-02-08T15:41:59Z

+1
Tested at: 1856d95
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17447/17691/summary.html

cmsbuild · 2017-02-08T15:42:02Z

Comparison job queued.

cmsbuild · 2017-02-08T17:36:53Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17447/17691/summary.html

dmitrijus · 2017-02-09T12:02:26Z

+1

cmsbuild · 2017-02-09T12:02:40Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

davidlange6 · 2017-02-10T09:08:19Z

+1

mtosi added 3 commits February 7, 2017 13:54

add validation for GsfTracks @HLT

d57dac8

fix eta range

a479d8a

fix

2536943

cmsbuild added this to the Next CMSSW_9_0_X milestone Feb 7, 2017

cmsbuild added comparison-pending dqm-pending orp-pending pending-signatures tests-pending labels Feb 7, 2017

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Feb 7, 2017

cmsbuild added tests-started and removed tests-pending labels Feb 7, 2017

makortel reviewed Feb 7, 2017

View reviewed changes

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Feb 7, 2017

clean

92aeea6

cmsbuild removed comparison-notrun dqm-approved fully-signed labels Feb 8, 2017

cmsbuild added the tests-pending label Feb 8, 2017

fix

e7bff2d

mtosi added 2 commits February 8, 2017 12:21

fix

269ffb2

fix

1856d95

cmsbuild added tests-started and removed tests-pending labels Feb 8, 2017

cmsbuild added tests-approved and removed tests-started labels Feb 8, 2017

cmsbuild added comparison-available and removed comparison-pending labels Feb 8, 2017

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Feb 9, 2017

cmsbuild added orp-approved and removed orp-pending labels Feb 10, 2017

cmsbuild merged commit 0c8662f into cms-sw:CMSSW_9_0_X Feb 10, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add validation for GsfTracks @HLT #17447

add validation for GsfTracks @HLT #17447

mtosi commented Feb 7, 2017

cmsbuild commented Feb 7, 2017

dmitrijus commented Feb 7, 2017

cmsbuild commented Feb 7, 2017 •

edited

cmsbuild commented Feb 7, 2017

makortel Feb 7, 2017

mtosi Feb 8, 2017

makortel Feb 8, 2017

makortel Feb 7, 2017

makortel Feb 7, 2017

makortel Feb 7, 2017

makortel Feb 7, 2017

makortel Feb 7, 2017

makortel Feb 7, 2017

makortel Feb 7, 2017

cmsbuild commented Feb 7, 2017

cmsbuild commented Feb 7, 2017

cmsbuild commented Feb 8, 2017

fcouderc commented Feb 8, 2017

cmsbuild commented Feb 8, 2017

makortel commented Feb 8, 2017

mtosi commented Feb 8, 2017

makortel commented Feb 8, 2017

cmsbuild commented Feb 8, 2017 •

edited

cmsbuild commented Feb 8, 2017

cmsbuild commented Feb 8, 2017

cmsbuild commented Feb 8, 2017

dmitrijus commented Feb 9, 2017

cmsbuild commented Feb 9, 2017

davidlange6 commented Feb 10, 2017

Navigation Menu

add validation for GsfTracks @HLT #17447

add validation for GsfTracks @HLT #17447

Conversation

mtosi commented Feb 7, 2017

cmsbuild commented Feb 7, 2017

dmitrijus commented Feb 7, 2017

cmsbuild commented Feb 7, 2017 • edited

cmsbuild commented Feb 7, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cmsbuild commented Feb 7, 2017

cmsbuild commented Feb 7, 2017

cmsbuild commented Feb 8, 2017

fcouderc commented Feb 8, 2017

cmsbuild commented Feb 8, 2017

makortel commented Feb 8, 2017

mtosi commented Feb 8, 2017

makortel commented Feb 8, 2017

cmsbuild commented Feb 8, 2017 • edited

cmsbuild commented Feb 8, 2017

cmsbuild commented Feb 8, 2017

cmsbuild commented Feb 8, 2017

dmitrijus commented Feb 9, 2017

cmsbuild commented Feb 9, 2017

davidlange6 commented Feb 10, 2017

cmsbuild commented Feb 7, 2017 •

edited

cmsbuild commented Feb 8, 2017 •

edited