Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code-cleaning in RecoMET/METProducers #1745

Merged
merged 19 commits into from Dec 12, 2013

Conversation

TaiSakuma
Copy link
Contributor

The constructor and the method produce() execute nearly entirely different sets of lines of code based on METtype.
https://github.com/TaiSakuma/cmssw/blob/CMSSW_7_0_0_pre9/RecoMET/METProducers/src/METProducer.cc

Instead of having a single producer which executes different lines based on METtype, we should have multiple producers, one producer for each METtype.

I also changed cfi files to use new producers.

I didn't delete METProducer yet. I plan to make another request in the future that will delete METProducer.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @TaiSakuma (Tai Sakuma) for CMSSW_7_0_X.

code-cleaning in RecoMET/METProducers

It involves the following packages:

RecoMET/METProducers

@nclopezo, @cmsbuild, @thspeer, @slava77 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #1745 was updated. @nclopezo, @cmsbuild, @thspeer, @slava77 can you please check and sign again.

@cmsbuild
Copy link
Contributor

Pull request #1745 was updated. @nclopezo, @cmsbuild, @thspeer, @slava77 can you please check and sign again.

@cmsbuild
Copy link
Contributor

@thspeer
Copy link
Contributor

thspeer commented Dec 11, 2013

+1
tested d9e38aa in CMSSW_7_0_X_2013-12-11-0200_1745
No difference in reco as expected, based on RelMon and reco script
Would be good indeed to remove METProducer so as not to create confusion.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

ktf added a commit that referenced this pull request Dec 12, 2013
Reco update -- Code-cleaning in RecoMET/METProducers
@ktf ktf merged commit e775ed1 into cms-sw:CMSSW_7_0_X Dec 12, 2013
@cmsbuild
Copy link
Contributor

ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
Advance fastjet-contrib to thread-friendly patch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants