New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
code-cleaning in RecoMET/METProducers #1745
Conversation
A new Pull Request was created by @TaiSakuma (Tai Sakuma) for CMSSW_7_0_X. code-cleaning in RecoMET/METProducers It involves the following packages: RecoMET/METProducers @nclopezo, @cmsbuild, @thspeer, @slava77 can you please review it and eventually sign? Thanks. |
+1 |
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it? |
Reco update -- Code-cleaning in RecoMET/METProducers
I'm curious why is there another run by jenkins? |
Advance fastjet-contrib to thread-friendly patch.
The constructor and the method produce() execute nearly entirely different sets of lines of code based on METtype.
https://github.com/TaiSakuma/cmssw/blob/CMSSW_7_0_0_pre9/RecoMET/METProducers/src/METProducer.cc
Instead of having a single producer which executes different lines based on METtype, we should have multiple producers, one producer for each METtype.
I also changed cfi files to use new producers.
I didn't delete METProducer yet. I plan to make another request in the future that will delete METProducer.